Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754716AbbDHUnj (ORCPT ); Wed, 8 Apr 2015 16:43:39 -0400 Received: from mga14.intel.com ([192.55.52.115]:46909 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753439AbbDHUnf (ORCPT ); Wed, 8 Apr 2015 16:43:35 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,545,1422950400"; d="asc'?scan'208";a="705726542" Message-ID: <1428525801.2579.6.camel@jtkirshe-mobl> Subject: Re: [PATCH v3 1/3] ixgbe, ixgbevf: Add new mbox API to enable MC promiscuous mode From: Jeff Kirsher To: Hiroshi Shimamoto Cc: Or Gerlitz , "vyasevic@redhat.com" , "e1000-devel@lists.sourceforge.net" , "Choi, Sy Jong" , "linux-kernel@vger.kernel.org" , David Laight , Hayato Momma , "netdev@vger.kernel.org" , Edward Cree , =?ISO-8859-1?Q?Bj=F8rn?= Mork Date: Wed, 08 Apr 2015 13:43:21 -0700 In-Reply-To: <7F861DC0615E0C47A872E6F3C5FCDDBD05E7CD29@BPXM14GP.gisp.nec.co.jp> References: <7F861DC0615E0C47A872E6F3C5FCDDBD05E7CD29@BPXM14GP.gisp.nec.co.jp> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-6NEZ30OKwBlh4vnNNxTe" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3260 Lines: 79 --=-6NEZ30OKwBlh4vnNNxTe Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2015-04-08 at 05:36 +0000, Hiroshi Shimamoto wrote: > From: Hiroshi Shimamoto >=20 > The limitation of the number of multicast address for VF is not enough > for the large scale server with SR-IOV feature. > IPv6 requires the multicast MAC address for each IP address to handle > the Neighbor Solicitation message. > We couldn't assign over 30 IPv6 addresses to a single VF interface. >=20 > The easy way to solve this is enabling multicast promiscuous mode. > It is good to have a functionality to enable multicast promiscuous > mode > for each VF from VF driver. >=20 > This patch introduces the new mbox API, IXGBE_VF_SET_MC_PROMISC, to > enable/disable multicast promiscuous mode in VF. If multicast > promiscuous mode is enabled the VF can receive all multicast packets. >=20 > With this patch, the ixgbevf driver automatically enable multicast > promiscuous mode when the number of multicast addresses is over than > 30 > if possible. >=20 > Signed-off-by: Hiroshi Shimamoto > Reviewed-by: Hayato Momma > CC: Choi, Sy Jong > --- >=20 > This adds new mbox API, but doesn't change the version because > v1.3 was newly added in the current dev-queue. > Is that okay, or shall I increment the version? >=20 > drivers/net/ethernet/intel/ixgbe/ixgbe.h | 1 + > drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h | 2 + > drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 76 > +++++++++++++++++++++++ > drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 3 + > drivers/net/ethernet/intel/ixgbevf/mbx.h | 2 + > drivers/net/ethernet/intel/ixgbevf/vf.c | 27 +++++++- > drivers/net/ethernet/intel/ixgbevf/vf.h | 1 + > 7 files changed, 111 insertions(+), 1 deletion(-) I will add this to my queue, thanks Hiroshi. --=-6NEZ30OKwBlh4vnNNxTe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJVJZLpAAoJEOVv75VaS+3OxPkP/0XH+MXpLkjNJw4yjXjU46GN Yvj2kCZk/oPOGK8a5wvjGtvQ3MtOYUqkT+JwJLAMELAi6xh0jhjE4gFXluSHgkdS LqFH+SmpfeR9rb4a8EMIFb+ixV2Qd+ZVR1+KStxta4qpc80wnMtaWK5hAovmh5iA 2qRDqxHa2NN+NmAFw7b7+7Jyy5lnuEIA63vOkXo/UXxBVPkNSs3FCGr52jE10OUE ZmsllKOa0e3HL8jV6pqSVWlQtL3+/6KTMfj+opbbfqAxQkGq5nW2XupGvavTrx6N 7AdLAbTJmSE0t6AzhMWlsX4EO+g7lGJH+LleJHCe7dSqMoTVlVG2MgWRo15trXf4 THXb3qCeim5PZMg+796jslAo1O5WmteeNj9nCDxvMQhlfQkjkW6zGaU5esMnzNiY 7U/rXwfIAQHElp754hg1n+eE7GIQMbbY6C8z2JD0/i8+TootZGBpmmpR5oLy4AKY TSffytZny2Dh1Rp0KyCy1JJ6g39mRPGgxzUBcK/Cl4Jd7v/n+nKnMrPaSSlV3y+T G1IM+hd6eXO3QZ3iq9Z04F2SKqE8oAhxCJua+1yD0OtFQCeGPJelgqWvSpxoQW/n syS+BrVlZUra9S0o/XexcaYPd+mrBePmPvFkciqh6/Y2X3gQdSvTNljIeUdkJ6xe GbsZvIrvrizUqbLksJcM =MCBJ -----END PGP SIGNATURE----- --=-6NEZ30OKwBlh4vnNNxTe-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/