Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932340AbbDHXUH (ORCPT ); Wed, 8 Apr 2015 19:20:07 -0400 Received: from TYO202.gate.nec.co.jp ([210.143.35.52]:60564 "EHLO tyo202.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754914AbbDHXUB (ORCPT ); Wed, 8 Apr 2015 19:20:01 -0400 From: Hiroshi Shimamoto To: Jeff Kirsher , Alexander Duyck , intel-wired-lan CC: Or Gerlitz , "vyasevic@redhat.com" , "e1000-devel@lists.sourceforge.net" , "netdev@vger.kernel.org" , "Choi, Sy Jong" , "linux-kernel@vger.kernel.org" , David Laight , Hayato Momma , Edward Cree , =?utf-8?B?QmrDuHJuIE1vcms=?= Subject: RE: [E1000-devel] [PATCH v3 3/3] ixgbe: Add new ndo to allow VF multicast promiscuous mode Thread-Topic: [E1000-devel] [PATCH v3 3/3] ixgbe: Add new ndo to allow VF multicast promiscuous mode Thread-Index: AdBxvjeKETmOwWVsS2egUfUGJzgZwwAP9dkAAABzVgAAFI+L0A== Date: Wed, 8 Apr 2015 23:18:08 +0000 Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD05E7D92D@BPXM14GP.gisp.nec.co.jp> References: <7F861DC0615E0C47A872E6F3C5FCDDBD05E7CDA0@BPXM14GP.gisp.nec.co.jp> <5525A876.2000407@gmail.com> <1428532092.2616.3.camel@jtkirshe-mobl.jf.intel.com> In-Reply-To: <1428532092.2616.3.camel@jtkirshe-mobl.jf.intel.com> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.205.5.123] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t38NKHdY011120 Content-Length: 3199 Lines: 74 > Subject: Re: [E1000-devel] [PATCH v3 3/3] ixgbe: Add new ndo to allow VF multicast promiscuous mode > > On Wed, 2015-04-08 at 15:15 -0700, Alexander Duyck wrote: > > On 04/07/2015 10:38 PM, Hiroshi Shimamoto wrote: > > > From: Hiroshi Shimamoto > > > > > > Implements the new netdev op to allow VF multicast promiscuous mode. > > > > > > The multicast promiscuous mode is not allowed for all VFs by default. > > > > > > The administrator can allow to VF multicast promiscuous mode for only > > > trusted VM. After allowing multicast promiscuous mode from the host, > > > we can use over 30 IPv6 addresses on VM. > > > # ip link set dev eth0 vf 1 mc_promisc on > > > > > > When disallowing multicast promiscuous mode, ixgbevf can only handle 30 > > > IPv6 addresses at most. > > > # ip link set dev eth0 vf 1 mc_promisc off > > > > > > Signed-off-by: Hiroshi Shimamoto > > > Reviewed-by: Hayato Momma > > > CC: Choi, Sy Jong > > > --- > > > drivers/net/ethernet/intel/ixgbe/ixgbe.h | 1 + > > > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 7 ++++++ > > > drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 32 ++++++++++++++++++++++++-- > > > drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.h | 2 ++ > > > 4 files changed, 40 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h b/drivers/net/ethernet/intel/ixgbe/ixgbe.h > > > index 08e65b6..4a9f74d 100644 > > > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h > > > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h > > > @@ -153,6 +153,7 @@ struct vf_data_storage { > > > u16 vlan_count; > > > u8 spoofchk_enabled; > > > bool rss_query_enabled; > > > + u8 mc_promisc_allowed; > > > unsigned int vf_api; > > > }; > > > > > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > > > index 2f41403..c0e07c5 100644 > > > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > > > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > > > @@ -3663,6 +3663,12 @@ static void ixgbe_configure_virtualization(struct ixgbe_adapter *adapter) > > > ixgbe_ndo_set_vf_rss_query_en(adapter->netdev, i, > > > adapter->vfinfo[i].rss_query_enabled); > > > } > > > + > > > + /* Reconfigure multicast promiscuous mode */ > > > + for (i = 0; i < adapter->num_vfs; i++) { > > > + ixgbe_ndo_set_vf_mc_promisc(adapter->netdev, i, > > > + adapter->vfinfo[i].mc_promisc_allowed); > > > + } > > > } > > > > > > static void ixgbe_set_rx_buffer_len(struct ixgbe_adapter *adapter) > > > > This doesn't need to be a separate loop. You can push it up into the > > block above since it is already looping through all VFs. > > > > Once that is fixed the rest of this patch and the other two looked fine > > to me. > > Hiroshi I am dropping this series and will await v4. > > Remember to send them to intel-wired-lan mailing list, please. yep, will do. thanks, Hiroshi ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?