Date: Thu, 9 Apr 2015 11:27:59 +0800
From: Baoquan He <bhe@redhat.com>
To: Dave Young <dyoung@redhat.com>
Cc: Xishi Qiu <qiuxishi@huawei.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, tglx@linutronix.de,
        akpm@linux-foundation.org, isimatu.yasuaki@jp.fujitsu.com,
        mingo@redhat.com, hpa@zytor.com
Subject: Re: [PATCH V2] x86/numa: kernel stack corruption fix
Message-ID: <20150409032759.GA18247@dhcp-16-105.nay.redhat.com>
References: <20150407134132.GA23522@dhcp-16-198.nay.redhat.com>
 <5524862F.6010709@huawei.com>
 <20150408014630.GF7213@localhost.localdomain>
 <55248B68.7000308@huawei.com>
 <20150408021836.GA2464@dhcp-16-105.nay.redhat.com>
 <55249572.7010600@huawei.com>
 <20150408030821.GG7213@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150408030821.GG7213@localhost.localdomain>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1250
Lines: 38

On 04/08/15 at 11:09am, Dave Young wrote:
> On 04/08/15 at 10:41am, Xishi Qiu wrote:
> > >> Hi Dave,
> > >>
> > >> I made a mistake, when numa is on, numa_meminfo is from SRAT, but it will be cut
> > >> in numa_cleanup_meminfo(), so the bug is not related to numa on/off. Your comment
> > >> is right.
> > > 
> > > Hi Xishi,
> > > 
> > >>From code flow it's exact as you said. And if remove numa=off bug should
> > > be reproduced alwasy. I talked to Dave, he said error didn't occur when
> > > he remove numa=off. That is too weird.
> > > 
> > 
> > Hi Baoquan,
> > 
> > May be it wrote over end of numa mask bitmap, but the stack can still run,
> > so there is no Call Trace. 
> > How about add some printk to see if it has written over? 
> 
> Oops, Redhat kdump always add numa=off in 2nd kernel commandline, but I did
> not notice I removed it during test.
> 
> So yes, the issue does not depend on numa=off.

OK, got it. thanks. Ack this patch.

Acked-by: Baoquan He <bhe@redhat.com>

Thanks
Baoquan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/