Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751938AbbDIHTE (ORCPT ); Thu, 9 Apr 2015 03:19:04 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:50782 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751592AbbDIHTB (ORCPT ); Thu, 9 Apr 2015 03:19:01 -0400 Message-ID: <552627BD.9060109@st.com> Date: Thu, 9 Apr 2015 09:18:21 +0200 From: Maxime Coquelin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Brian Norris , Tejun Heo , Peter Griffin CC: , , , , Srinivas Kandagatla , Patrice Chotard Subject: Re: [PATCH] ata: ahci_st: fixup layering violations / drvdata errors References: <1428519599-31885-1-git-send-email-computersforpeace@gmail.com> In-Reply-To: <1428519599-31885-1-git-send-email-computersforpeace@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.201.23.80] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.13.68,1.0.33,0.0.0000 definitions=2015-04-09_01:2015-04-08,2015-04-09,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1572 Lines: 43 Hello Brian, On 04/08/2015 08:59 PM, Brian Norris wrote: > When working on another SATA driver that uses libahci_platform, I > noticed an error in this driver; it tries to the the driver data for its > device, while libata also thinks it can set the driver data. See: > > ahci_platform_init_host() > -> ata_host_alloc_pinfo() > -> ata_host_alloc() > -> dev_set_drvdata() > > So instead of sticking the IP-specific platform data into drvdata, let's > use the plat_data variable that is reserved for this use. > > Signed-off-by: Brian Norris > Cc: Srinivas Kandagatla > Cc: Maxime Coquelin > Cc: Patrice Chotard > --- > This is ONLY compile tested; I don't have hardware to run. This looks like it > could have ramifications on suspend/resume support, and hot device removal > (e.g., sysfs unbind), so it might qualify as -stable, if someone can test it > > drivers/ata/ahci_st.c | 25 ++++++++++++++----------- > 1 file changed, 14 insertions(+), 11 deletions(-) > > Your patch looks sensible, thanks for spotting this issue. Peter, do you have the SATA setup in place to test Brian's patch? Once tested, you can add my: Acked-by: Maxime Coquelin Thanks, Maxime -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/