Date: Thu, 9 Apr 2015 09:37:44 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
Cc: mingo@redhat.com, bp@suse.de, tglx@linutronix.de, hpa@zytor.com,
        x86@kernel.org, linux-kernel@vger.kernel.org, konrad.wilk@oracle.com
Subject: Re: [PATCH] x86, iommu: Fix header comments regarding standard and
 _FINISH macros
Message-ID: <20150409073743.GB31471@gmail.com>
References: <1428508017-5316-1-git-send-email-Aravind.Gopalakrishnan@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1428508017-5316-1-git-send-email-Aravind.Gopalakrishnan@amd.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1974
Lines: 50


* Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com> wrote:

> The comment line regarding IOMMU_INIT and IOMMU_INIT_FINISH macros
> is incorrect:
> "The standard vs the _FINISH differs in that the _FINISH variant will
>  continue detecting other IOMMUs in the call list..."
> It should be "..the *standard* variant will continue detecting..."
> 
> Fix that.
> 
> Signed-off-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
> ---
>  arch/x86/include/asm/iommu_table.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/include/asm/iommu_table.h b/arch/x86/include/asm/iommu_table.h
> index f42a047..16845d4 100644
> --- a/arch/x86/include/asm/iommu_table.h
> +++ b/arch/x86/include/asm/iommu_table.h
> @@ -79,7 +79,7 @@ struct iommu_table_entry {
>   *  d). Similar to the 'init', except that this gets called from pci_iommu_init
>   *      where we do have a memory allocator.
>   *
> - * The standard vs the _FINISH differs in that the _FINISH variant will
> + * The standard vs the _FINISH differs in that the standard variant will
>   * continue detecting other IOMMUs in the call list after the
>   * the detection routine returns a positive number. The _FINISH will
>   * stop the execution chain. Both will still call the 'init' and

So while we are touching it, how about making it more readable:

    *
    * The standard vs the _FINISH variants differ in that the
    * standard variant will continue detecting other IOMMUs in the 
    * call list after the detection routine returns a positive number. 
    * The _FINISH variant will stop the execution chain. Both variants 
    * will still call the 'init' and ...
    *

I also fixed a 'the the' typo.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/