Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753287AbbDIHjQ (ORCPT ); Thu, 9 Apr 2015 03:39:16 -0400 Received: from mail-vn0-f52.google.com ([209.85.216.52]:37416 "EHLO mail-vn0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751499AbbDIHjO (ORCPT ); Thu, 9 Apr 2015 03:39:14 -0400 MIME-Version: 1.0 In-Reply-To: <552511E5.9060005@hurleysoftware.com> References: <1428485466-24326-1-git-send-email-kuleshovmail@gmail.com> <1428485519-25587-1-git-send-email-kuleshovmail@gmail.com> <552511E5.9060005@hurleysoftware.com> Date: Thu, 9 Apr 2015 13:39:13 +0600 Message-ID: Subject: Re: [PATCH 2/2] x86/earlyprintk: setup earlyprintk as early as possible From: Alexander Kuleshov To: Peter Hurley Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Greg Kroah-Hartman , Yinghai Lu , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 981 Lines: 30 Hello Peter, 2015-04-08 17:32 GMT+06:00 Peter Hurley : >> + >> +void setup_early_serial_console() { > > If you put this function in kernel/early_printk.c, then > setup_early_printk() can remain file scope. > Yes, right. will fix it. > > The WARN is still required here because the register_console() caller > is not always obvious. > > A better way to achieve what you want is to not re-register the console > to begin with. Looking at early_console_register() and setup_early_printk(), > it seems like re-registration would already be prevented (since early_console > != 0 after the first call to early_console_register())? Have you tried this? > hmm, now, thanks for the point will test it. Thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/