Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934579AbbDIJbr (ORCPT ); Thu, 9 Apr 2015 05:31:47 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38541 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934567AbbDIJbd (ORCPT ); Thu, 9 Apr 2015 05:31:33 -0400 Date: Thu, 9 Apr 2015 11:31:30 +0200 From: Greg KH To: Matthew Garrett Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] usb: Prefer firmware values when determining whether a port is removable Message-ID: <20150409093130.GC883@kroah.com> References: <1428536161-2978-1-git-send-email-mjg59@coreos.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428536161-2978-1-git-send-email-mjg59@coreos.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 961 Lines: 25 On Wed, Apr 08, 2015 at 04:36:00PM -0700, Matthew Garrett wrote: > Windows appears to pay more attention to the ACPI values than any hub > configuration, so prefer the firmware's opinion on whether a port is > fixed or removable before falling back to the hub values. > > Signed-off-by: Matthew Garrett > --- > drivers/usb/core/hub.c | 32 +++++++++++++++++--------------- > 1 file changed, 17 insertions(+), 15 deletions(-) I like your trust in firmware :) Anyway, is this all a Windows 8 requirement? If so, I'll feel comfortable making these changes, otherwise we are at the mercy of the bios people to randomly get things right, and we all know how often that works... thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/