Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934594AbbDIKcR (ORCPT <rfc822;w@1wt.eu>);
	Thu, 9 Apr 2015 06:32:17 -0400
Received: from mail1.bemta3.messagelabs.com ([195.245.230.164]:6571 "EHLO
	mail1.bemta3.messagelabs.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S933011AbbDIKcN (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 9 Apr 2015 06:32:13 -0400
X-Env-Sender: stwiss.opensource@diasemi.com
X-Msg-Ref: server-2.tower-39.messagelabs.com!1428575495!21797362!1
X-Originating-IP: [94.185.165.51]
X-StarScan-Received: 
X-StarScan-Version: 6.13.6; banners=-,-,-
X-VirusChecked: Checked
From: "Opensource [Steve Twiss]" <stwiss.opensource@diasemi.com>
To: Lee Jones <lee.jones@linaro.org>
CC: Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Mark Rutland <mark.rutland@arm.com>,
        Pawel Moll <pawel.moll@arm.com>, Rob Herring <robh+dt@kernel.org>,
        DT <devicetree@vger.kernel.org>,
        David Dajun Chen <david.chen@diasemi.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        INPUT <linux-input@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "Samuel Ortiz" <sameo@linux.intel.com>
Subject: RE: [PATCH V1 2/2] devicetree: Add bindings for DA9063 OnKey
Thread-Topic: [PATCH V1 2/2] devicetree: Add bindings for DA9063 OnKey
Thread-Index: AQHQcgzzgiPaxU6PeUyDd/9gTiDOOZ1EWEwAgAAe6jA=
Date: Thu, 9 Apr 2015 10:31:34 +0000
Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7014B2139F9@SW-EX-MBX02.diasemi.com>
References: <cover.1428504804.git.stwiss.opensource@diasemi.com>
 <addbebc419ed2d693d398e07131c119cd1d4160b.1428504804.git.stwiss.opensource@diasemi.com>
 <20150409092138.GA3467@x1>
In-Reply-To: <20150409092138.GA3467@x1>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.20.26.77]
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id t39AWNuj015240
Content-Length: 1426
Lines: 44

On 09 April 2015 10:22 Lee Jones wrote

> > From: Steve Twiss <stwiss.opensource@diasemi.com>
> What format is this?  Why aren't you using `git send-email`?

I am using a git format-patch to generate the patches but our in-house IT
department complications disallow the use of git send-email.

> > This patch is dependent on PATCH V1 1/2
> How can there be dependencies between a binding document and a driver
> patch?

I'll remove those circular dependencies for the next patch

> > +- onkey : This node defines the OnKey settings for controlling the key
> > +  functionality of the device. The node should contain the compatible
> keyword
> 
> s/keyword/property/

... will do that search and replace

> > +  DA9063_REG_CONFIG_I and the device tree entry "dlg,disable-key-
> power" can
> 
> I feel like you're burying the dlg,disable-key-power documentation in
> side a long winded paragraph.  It's better to start the line with it,
> like:
> 
> Optional Properties:
> 
> dlg,disable-key-power:  Disable power-down using a long key-press.  If
> 			absent <blah> ...
> 

okay, I'll make that change.

Thanks for the comments,
I'll send PATCH V2 after I make the changes requested by yourself and Paul Bolle
(see https://lkml.org/lkml/2015/4/9/150).

Regards,
Steve
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?