Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933611AbbDILuG (ORCPT ); Thu, 9 Apr 2015 07:50:06 -0400 Received: from down.free-electrons.com ([37.187.137.238]:59854 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932726AbbDILuE (ORCPT ); Thu, 9 Apr 2015 07:50:04 -0400 Date: Thu, 9 Apr 2015 13:49:19 +0200 From: Maxime Ripard To: Peter Hurley Cc: Vinod Koul , Felipe Balbi , Laurent Pinchart , Linux kernel Subject: Re: [4.0-rc+] WARNING: CPU: 0 PID: 1 at ./drivers/dma/dmaengine.c:863 dma_async_device_register+0xe0/0x540() Message-ID: <20150409114919.GM26727@lukather> References: <54F87075.5020105@hurleysoftware.com> <20150305161236.GG2613@intel.com> <55254EFD.10700@hurleysoftware.com> <20150408155945.GG26727@lukather> <55255232.40700@hurleysoftware.com> <20150409070927.GI26727@lukather> <552654F1.6020300@hurleysoftware.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HVCoas+krw6dou6l" Content-Disposition: inline In-Reply-To: <552654F1.6020300@hurleysoftware.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3195 Lines: 84 --HVCoas+krw6dou6l Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 09, 2015 at 06:31:13AM -0400, Peter Hurley wrote: > On 04/09/2015 03:09 AM, Maxime Ripard wrote: > > On Wed, Apr 08, 2015 at 12:07:14PM -0400, Peter Hurley wrote: > >> On 04/08/2015 11:59 AM, Maxime Ripard wrote: > >>> On Wed, Apr 08, 2015 at 11:53:33AM -0400, Peter Hurley wrote: > >>>> On 03/05/2015 11:12 AM, Vinod Koul wrote: > >>>>> On Thu, Mar 05, 2015 at 10:04:21AM -0500, Peter Hurley wrote: > >>>>>>> First boot of 4.0-rc+ gave me [1] on a Beaglebone Black due to > >>>>>>> > >>>>> The warning is intentional to get driver fixed and give the right b= ehaviour > >>>>> > >>>>> Felipe had sent a patch for this but that one needs an update > >>>> > >>>> Vinod, > >>>> > >>>> Felipe's patch never made it to mainline, and this warning is=20 > >>>> still happening on 4.0-rc7 so please revert for 4.0-final. > >>> > >>> That patch isn't introducing any regression. I fail to see how that > >>> justifies a revert so late in the release cycle. > >> > >> Arguably it never should have been introduced in the first place > >=20 > > Upon which arguments? So far, I've seen none but "my boot logs look > > bad now". >=20 > 1. Every subsystem has drivers that don't fully conform to a desired > interface. If even a small fraction did this, everyone's logs would > be cluttered with this garbage. For that matter, if just the serial > subsystem alone did this, logs would be awash in warnings. And a lot of subsystems do this for drivers where the way to fix this is not clear and/or easy to obtain. Which is exactly the case here. > 2. Now _every_ dmaengine driver "fix" for this will need to be pushed > to -stable. It won't. Such changes are not elligible, especially since they are not critical fixes. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --HVCoas+krw6dou6l Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVJmc/AAoJEBx+YmzsjxAgn+gP/jFnNeCo8l+l0eSccmzMjB/I A5l6sp6J6askJqn9JVmn0O4l+ub/1ifDMjcI8cxrULynK7B0CHp9FphMxDDEb7Yn sy/M17AnEo1avxGsm7meYHYKIRZmRqhzo3PGZe3qyxE7VQvK5UANWHb9A79UevVO XE0AEE9dUyOXrNjO2St+ng/2WAIYfcrvPVqZ5y5VnJism8jVlUVZxr4mapA7X1VI WPYSffm+clZlTMEhnpgaVzBcbKUqJvQReFFbHpoga/WZE65PLYwJ8A8HmGbS5h30 PS3e6BW/IOMKPOh00h3OQpkZEn8qiJUOy0skWeX2Z74gcXhSxuXkDvvjzsv7jtHE U3cxgVcvkNqbg39Woe0iFwvAXZ/ggfrACa0Xm/qOXOAW9B/q7E0/Ytsbgx22GGvv rbm7uwMLuR/1Xz5u72rQDeTVO6GFPFt75oMbuZ80dWwYOs6m7z7YmvP4gOwAKBi7 cKqJOF84K+NfgaDIsR3gtx7P0np34wnpqjThBR/pzIePO3cuispDNOekXog3YxKc 8RNr/5Wxot6fmqhPBi/M3/Y4pnIcMUuXR4HW8LV0IEik/xd6DGrTqttHZX/x4EBB dDQ0UfuDnBsTu2E9wt+6b1ekeZDV7ZMyQgC5D2NUGE05k29LvkkkXXOt1Upctwky VsbgCd8GsCeDomRh6GQ8 =OPZp -----END PGP SIGNATURE----- --HVCoas+krw6dou6l-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/