Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755266AbbDIMcB (ORCPT ); Thu, 9 Apr 2015 08:32:01 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:35045 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752871AbbDIMb6 (ORCPT ); Thu, 9 Apr 2015 08:31:58 -0400 Date: Thu, 9 Apr 2015 14:31:55 +0200 From: Pavel Machek To: Sebastian Reichel Cc: Sakari Ailus , Andrew Morton , pali.rohar@gmail.com, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com, galak@codeaurora.org, bcousson@baylibre.com, m.chehab@samsung.com, devicetree@vger.kernel.org, mchehab@osg.samsung.com, hverkuil@xs4all.nl Subject: [PATCHv7] media: i2c/adp1653: fix includes Message-ID: <20150409123155.GB9563@amd> References: <20150403202624.GA4308@amd> <20150403213655.GO20756@valkosipuli.retiisi.org.uk> <20150404074337.GA31064@amd> <20150404102435.GR20756@valkosipuli.retiisi.org.uk> <20150404171116.GA15025@Nokia-N900> <20150404200307.GS20756@valkosipuli.retiisi.org.uk> <20150409074238.GA22603@amd> <20150409091017.GA4526@earth> <20150409112943.GA31173@amd> <20150409121913.GB18713@earth> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150409121913.GB18713@earth> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1950 Lines: 59 Fix includes according to Sebastian. Signed-off-by: Pavel Machek --- On Thu 2015-04-09 14:19:14, Sebastian Reichel wrote: > On Thu, Apr 09, 2015 at 01:29:43PM +0200, Pavel Machek wrote: > > On Thu 2015-04-09 11:10:17, Sebastian Reichel wrote: > > > On Thu, Apr 09, 2015 at 09:42:38AM +0200, Pavel Machek wrote: > > > > [...] > > > > +#include > > > > +#include > > > > [...] > > > > > > This should probably be > > > > > > #include > > > #include > > > > And I thought people would only bikesched paint on the > > Documentation. Sakari, feel free to change that, but > > > a) I don't see why Sebastian's version is better > > You neither use nor . > > Well "include/linux/gpio.h" describes the old gpio API. The new > gpiod gpiod API is described in "include/linux/gpio/consumer.h" and > you use it, so the include should be included ;) > > You don't use anything from "include/linux/of_gpio.h", but it > includes "include/linux/of.h", which you are using. So you should > include instead ;) diff --git a/drivers/media/i2c/adp1653.c b/drivers/media/i2c/adp1653.c index d703636..7107ac2 100644 --- a/drivers/media/i2c/adp1653.c +++ b/drivers/media/i2c/adp1653.c @@ -35,8 +35,8 @@ #include #include #include -#include -#include +#include +#include #include #include -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/