Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755299AbbDIMoE (ORCPT ); Thu, 9 Apr 2015 08:44:04 -0400 Received: from mail-wg0-f42.google.com ([74.125.82.42]:35646 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755107AbbDIMoA (ORCPT ); Thu, 9 Apr 2015 08:44:00 -0400 MIME-Version: 1.0 X-Originating-IP: [95.23.56.200] In-Reply-To: <20150409123155.GB9563@amd> References: <20150403202624.GA4308@amd> <20150403213655.GO20756@valkosipuli.retiisi.org.uk> <20150404074337.GA31064@amd> <20150404102435.GR20756@valkosipuli.retiisi.org.uk> <20150404171116.GA15025@Nokia-N900> <20150404200307.GS20756@valkosipuli.retiisi.org.uk> <20150409074238.GA22603@amd> <20150409091017.GA4526@earth> <20150409112943.GA31173@amd> <20150409121913.GB18713@earth> <20150409123155.GB9563@amd> Date: Thu, 9 Apr 2015 14:43:59 +0200 Message-ID: Subject: Re: [PATCHv7] media: i2c/adp1653: fix includes From: Javier Martinez Canillas To: Pavel Machek Cc: Sebastian Reichel , Sakari Ailus , Andrew Morton , pali.rohar@gmail.com, kernel list , linux-arm-kernel , "linux-omap@vger.kernel.org" , Tony Lindgren , Kevin Hilman , Aaro Koskinen , ivo.g.dimitrov.75@gmail.com, Patrik Bachan , Kumar Gala , Benoit Cousson , m.chehab@samsung.com, "devicetree@vger.kernel.org" , mchehab@osg.samsung.com, hverkuil@xs4all.nl Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2036 Lines: 63 Hello Pavel, On Thu, Apr 9, 2015 at 2:31 PM, Pavel Machek wrote: > Fix includes according to Sebastian. > > Signed-off-by: Pavel Machek > > --- > > On Thu 2015-04-09 14:19:14, Sebastian Reichel wrote: >> On Thu, Apr 09, 2015 at 01:29:43PM +0200, Pavel Machek wrote: >> > On Thu 2015-04-09 11:10:17, Sebastian Reichel wrote: >> > > On Thu, Apr 09, 2015 at 09:42:38AM +0200, Pavel Machek wrote: >> > > > [...] >> > > > +#include >> > > > +#include >> > > > [...] >> > > >> > > This should probably be >> > > >> > > #include >> > > #include >> > >> > And I thought people would only bikesched paint on the >> > Documentation. Sakari, feel free to change that, but >> >> > a) I don't see why Sebastian's version is better >> >> You neither use nor . >> >> Well "include/linux/gpio.h" describes the old gpio API. The new >> gpiod gpiod API is described in "include/linux/gpio/consumer.h" and >> you use it, so the include should be included ;) >> >> You don't use anything from "include/linux/of_gpio.h", but it >> includes "include/linux/of.h", which you are using. So you should >> include instead ;) > > diff --git a/drivers/media/i2c/adp1653.c b/drivers/media/i2c/adp1653.c > index d703636..7107ac2 100644 > --- a/drivers/media/i2c/adp1653.c > +++ b/drivers/media/i2c/adp1653.c > @@ -35,8 +35,8 @@ > #include > #include > #include > -#include > -#include > +#include > +#include > #include > #include > Please re-spin your previous patch and submit it properly. Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/