Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755163AbbDINKL (ORCPT ); Thu, 9 Apr 2015 09:10:11 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:36197 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753624AbbDINKI (ORCPT ); Thu, 9 Apr 2015 09:10:08 -0400 Message-ID: <55267A2F.5050609@6wind.com> Date: Thu, 09 Apr 2015 15:10:07 +0200 From: Nicolas Dichtel Reply-To: nicolas.dichtel@6wind.com Organization: 6WIND User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Paul Moore CC: davem@davemloft.net, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/5] selinux/nlmsg: add RTM_GETNSID References: <1428511002-22329-1-git-send-email-nicolas.dichtel@6wind.com> <1428511002-22329-3-git-send-email-nicolas.dichtel@6wind.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1083 Lines: 22 Le 09/04/2015 13:10, Paul Moore a écrit : [snip] >> --- a/security/selinux/nlmsgtab.c >> +++ b/security/selinux/nlmsgtab.c >> @@ -74,6 +74,7 @@ static struct nlmsg_perm nlmsg_route_perms[] = >> { RTM_DELMDB, NETLINK_ROUTE_SOCKET__NLMSG_WRITE }, >> { RTM_GETMDB, NETLINK_ROUTE_SOCKET__NLMSG_READ }, >> { RTM_NEWNSID, NETLINK_ROUTE_SOCKET__NLMSG_WRITE }, >> + { RTM_DELNSID, NETLINK_ROUTE_SOCKET__NLMSG_READ }, >> { RTM_GETNSID, NETLINK_ROUTE_SOCKET__NLMSG_READ }, >> }; > > Can you elaborate a bit on the RTM_DELNSID type? Based only on the > name I wonder if it should be treated as a "write" and not a "read" > operation. The user is not allowed to delete a nsid (no method is implemented). This RTM_DELNSID is only used for notifications. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/