Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754237AbbDIOqy (ORCPT ); Thu, 9 Apr 2015 10:46:54 -0400 Received: from seldrel01.sonyericsson.com ([212.209.106.2]:4405 "EHLO seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753055AbbDIOqx (ORCPT ); Thu, 9 Apr 2015 10:46:53 -0400 Message-ID: <55269054.6030703@sonymobile.com> Date: Thu, 9 Apr 2015 07:44:36 -0700 From: Tim Bird User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Iulia Manda , "josh@joshtriplett.org" CC: "linux-embedded@vger.kernel.org" , "paulmck@linux.vnet.ibm.com" , "dvhart@linux.intel.com" , "peterz@infradead.org" , "mihai.caraman@freescale.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/3] kernel: Add a new config option to remove command line parsing References: <1427898893-8257-1-git-send-email-iulia.manda21@gmail.com> In-Reply-To: <1427898893-8257-1-git-send-email-iulia.manda21@gmail.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1392 Lines: 38 On 04/01/2015 07:34 AM, Iulia Manda wrote: > This patch introduces CONFIG_CMDLINE_PARSE option which conditionally compiles > the support for parsing kernel command line arguments. The corresponding > functions that actually do the parsing will be compiled out. > > This is used when no parameters will be specified neither at compile time nor at > boot time. > > Bloat-o-meter output (compared to the preivous version in which builtin cmdline > was also set to 'Y'): > > add/remove: 0/8 grow/shrink: 0/6 up/down: 0/-3669 (-3669) I think this is great stuff. (Of course, having research something like this previously, I'm a bit biased.) It's very nice to have the Bloat-o-meter output for these kernel size shrinking patches. The patch itself looks very straightforward, and I don't see any problems in a visual inspection. You can add a Reviewed-by: Tim Bird to this patch. I'd like to be able to point people to this on the mailing list. In the future can you make sure to CC: , so there's a reference on lkml.org I can point people to? Thanks for this great work! -- Tim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/