Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933173AbbDIRHx (ORCPT ); Thu, 9 Apr 2015 13:07:53 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:51689 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933100AbbDIRHv (ORCPT ); Thu, 9 Apr 2015 13:07:51 -0400 Date: Thu, 9 Apr 2015 19:07:33 +0200 From: Peter Zijlstra To: Chris Metcalf Cc: Frederic Weisbecker , "Paul E. McKenney" , "Rafael J. Wysocki" , Martin Schwidefsky , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/2] nohz: add tick_nohz_full_cpumask_or() and _andnot() APIs Message-ID: <20150409170733.GR21418@twins.programming.kicks-ass.net> References: <20150409082921.GP27490@worktop.programming.kicks-ass.net> <1428598839-24296-1-git-send-email-cmetcalf@ezchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428598839-24296-1-git-send-email-cmetcalf@ezchip.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 663 Lines: 18 On Thu, Apr 09, 2015 at 01:00:38PM -0400, Chris Metcalf wrote: > +static inline void tick_nohz_full_cpumask_or(struct cpumask *mask) This still reads as if you're doing: nohz_full_mask |= mask. I think the suggestion done by Frederic is the right one, reverse the lot, have: isolcpu_map_or(nohz_full_map) := isolcpus_map |= nohz_full_map Or just completely give up and just write readable code under an #ifdef. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/