Message-ID: <5526B1F9.3020002@oracle.com>
Date: Thu, 09 Apr 2015 11:08:09 -0600
From: David Ahern <david.ahern@oracle.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Don Zickus <dzickus@redhat.com>
CC: acme@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: Fix ppid for non-main thread
References: <1428598107-178999-1-git-send-email-david.ahern@oracle.com> <20150409170519.GK175361@redhat.com>
In-Reply-To: <20150409170519.GK175361@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1040
Lines: 23

On 4/9/15 11:05 AM, Don Zickus wrote:
> On Thu, Apr 09, 2015 at 12:48:27PM -0400, David Ahern wrote:
>> >Commit ca6c41c59b9 sets the ppid based on what is read from the
>> >/proc/pid/status file when synthesizing fork events. This is correct
>> >thing to do for new processes but not threads of a process. Fix
>> >ppid for threads to be the main thread when synthesizing fork events
>> >(ie., assume main thread spawned all sub-threads in a process).
> That sounds right.:-)   Sorry I should have noticed that a couple of weeks
> ago.
>
> Acked-by: Don Zickus<dzickus@redhat.com>
>

I believe this explains the performance delta you noticed with 
specjbb/jvm. Arnaldo is the one that figured out the performance hit is 
from cloning maps; from that analysis I realized what the goof was.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/