Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933700AbbDIURl (ORCPT ); Thu, 9 Apr 2015 16:17:41 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:18465 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933212AbbDIURk (ORCPT ); Thu, 9 Apr 2015 16:17:40 -0400 X-IronPort-AV: E=Sophos;i="5.11,552,1422918000"; d="scan'208";a="109033000" Date: Thu, 9 Apr 2015 22:17:30 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Fabian Frederick cc: linux-kernel@vger.kernel.org, "J. Bruce Fields" , Gilles Muller , Nicolas Palix , Michal Marek , cocci@systeme.lip6.fr Subject: Re: [PATCH 1/1 linux-next] scripts/coccinelle/misc/bugon.cocci: update bug_on conversion warning In-Reply-To: <1428610422-25075-1-git-send-email-fabf@skynet.be> Message-ID: References: <1428610422-25075-1-git-send-email-fabf@skynet.be> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1467 Lines: 45 On Thu, 9 Apr 2015, Fabian Frederick wrote: > if()/BUG conversion to BUG_ON must be avoided when there's side effect > in condition. The reason being BUG_ON won't execute condition when CONFIG_BUG > is not defined. > > Inspired-by: J. Bruce Fields > Suggested-by: Julia Lawall > Signed-off-by: Fabian Frederick Acked by: Julia Lawall modulo the suggestion below. > --- > scripts/coccinelle/misc/bugon.cocci | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/coccinelle/misc/bugon.cocci b/scripts/coccinelle/misc/bugon.cocci > index 3b7eec2..0d18022 100644 > --- a/scripts/coccinelle/misc/bugon.cocci > +++ b/scripts/coccinelle/misc/bugon.cocci > @@ -57,6 +57,6 @@ coccilib.org.print_todo(p[0], "WARNING use BUG_ON") > p << r.p; > @@ > > -msg="WARNING: Use BUG_ON" > +msg="WARNING: Use BUG_ON instead of if condition followed by BUG.\nPlease make sure condition has no side effects (see conditional BUG_ON definition in include/asm-generic/bug.h)" > coccilib.report.print_report(p[0], msg) "make sure condition" would be nicer as "make sure the condition". thanks, julia > -- > 1.9.1 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/