From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: David Rientjes <rientjes@google.com>,
        Andrey Ryabinin <a.ryabinin@samsung.com>, linux-mm@kvack.org,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mempool: add missing include
Date: Thu, 09 Apr 2015 23:14:14 +0200
Message-ID: <6079838.EgducKeYG3@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <alpine.DEB.2.10.1504091230400.11370@chino.kir.corp.google.com>
References: <3302342.cNyRUGN06P@wuerfel> <alpine.DEB.2.10.1504091230400.11370@chino.kir.corp.google.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1434
Lines: 35

On Thursday 09 April 2015 12:31:05 David Rientjes wrote:
> On Thu, 9 Apr 2015, Arnd Bergmann wrote:
> 
> > This is a fix^3 for the mempool poisoning patch, which introduces
> > a compile-time error on some ARM randconfig builds:
> > 
> > mm/mempool.c: In function 'check_element':
> > mm/mempool.c:65:16: error: implicit declaration of function 'kmap_atomic' [-Werror=implicit-function-declaration]
> >    void *addr = kmap_atomic((struct page *)element);
> > 
> > The problem is clearly the missing declaration, and including
> > linux/highmem.h fixes it.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: a3db5a8463b0db ("mm, mempool: poison elements backed by page allocator fix fix")
> 
> Acked-by: David Rientjes <rientjes@google.com>
> 
> Thanks!  Can you confirm that this is because CONFIG_BLOCK is disabled and 
> not something else?

Unfortunately I've lost the information which build was responsible
for this error (normally I keep it, but my script failed here because the
same config introduced two new regressions). CONFIG_BLOCK sounds plausible
here.

If necessary, I can repeat the last few hundred builds without this
patch to find out what it was.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/