Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756302AbbDIVSA (ORCPT ); Thu, 9 Apr 2015 17:18:00 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:55916 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754298AbbDIVR5 (ORCPT ); Thu, 9 Apr 2015 17:17:57 -0400 From: Arnd Bergmann To: Kumar Gala Cc: linux-arm-msm@vger.kernel.org, Abhimanyu Kapur , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arm@kernel.org, catalin.marinas@arm.com, will.deacon@arm.com Subject: Re: [RFC PATCH 4/5] arm64: smp: move the pen to a header file Date: Thu, 09 Apr 2015 23:17:48 +0200 Message-ID: <6018110.XP6YK3PMra@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1428601031-5366-5-git-send-email-galak@codeaurora.org> References: <1428601031-5366-1-git-send-email-galak@codeaurora.org> <1428601031-5366-5-git-send-email-galak@codeaurora.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:71iYIIY2HaiilQF7FAJwM2Aiw4FANG6/bqlBJhtoFPf8jm0g6pv Fqfpx44InnlO90rmlu5IaEhM5HxIsVu6sIXOG7dMp7hbS2kkK0iWHnq7DLAvWlKpPYWwjJp aFfxYBovxN5NxqqiKTDu6v/iIgs/arhfXQsb0Q/G89F4gcotuATt6FDG57yJSJjCr6Wb7RB XCcXV6a3gPucFCybAjMLw== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 770 Lines: 20 On Thursday 09 April 2015 12:37:10 Kumar Gala wrote: > From: Abhimanyu Kapur > > Move the secondary_pen_release variable and the secondary_holding_pen > entry function to asm/smp_plat.h so that the other cpu ops implementations > can share them. > > Signed-off-by: Abhimanyu Kapur > Signed-off-by: Kumar Gala > I don't believe your SMP implementation can be so broken to require this. Please fix the code instead to not use a holding pen. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/