Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754049AbbDIV51 (ORCPT ); Thu, 9 Apr 2015 17:57:27 -0400 Received: from mail-ig0-f180.google.com ([209.85.213.180]:38127 "EHLO mail-ig0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752818AbbDIV5Y (ORCPT ); Thu, 9 Apr 2015 17:57:24 -0400 MIME-Version: 1.0 In-Reply-To: <20150409203914.GA16868@dtor-glaptop> References: <20150409203914.GA16868@dtor-glaptop> Date: Thu, 9 Apr 2015 14:57:24 -0700 X-Google-Sender-Auth: -E3JeC8_cfQAULAYKYg1OnPIVw0 Message-ID: Subject: Re: [PATCH] platform/chrome: chromeos_laptop - do not probe devices on Pixel 1 From: Benson Leung To: Dmitry Torokhov Cc: Olof Johansson , Nick Dyer , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1646 Lines: 42 On Thu, Apr 9, 2015 at 1:39 PM, Dmitry Torokhov wrote: > Atmel MXT devices use different i2c addresses, depending on the current > mode of operation (bootloader or application). The Atmel MXT driver > expects i2c client's address contain the application address of the > chip, and calculates the expected bootloader address form the > application address. Unfortunately chrome_laptop does probe the devices s/chrome_laptop/chromeos_laptop > and if touchpad (or touchscreen, or both) comes up in bootloader mode > the i2c device gets instantiated with the bootloader address, instead of > application address, which confuses the driver. > > Given that hardware on Pixel is set and is not going to change let's not > try to probe devices to see if they are present or not, but rather > instantiate them always at expected addresses. > > Since all devices are now probed and/or instantiated at given address, > we no longer need to support probing multiple addresses for the same > device. > > Signed-off-by: Dmitry Torokhov > --- Also, since we no longer probe for the bootloader addresses, you should remove the following two unused defines too : #define ATMEL_TP_I2C_BL_ADDR 0x25 #define ATMEL_TS_I2C_BL_ADDR 0x26 Otherwise : Reviewed-by: Benson Leung -- Benson Leung Software Engineer, Chrom* OS bleung@chromium.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/