Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932130AbbDIWio (ORCPT ); Thu, 9 Apr 2015 18:38:44 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53225 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753573AbbDIWin (ORCPT ); Thu, 9 Apr 2015 18:38:43 -0400 Date: Fri, 10 Apr 2015 00:38:39 +0200 From: Greg Kroah-Hartman To: Mitchel Humpherys Cc: devel@linuxdriverproject.org, Android Kernel Team , Colin Cross , John Stultz , linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: ion: chunk_heap: use %pa for printing dma_addr_t's Message-ID: <20150409223839.GA24054@kroah.com> References: <1428618674-1370-1-git-send-email-mitchelh@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428618674-1370-1-git-send-email-mitchelh@codeaurora.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2085 Lines: 42 On Thu, Apr 09, 2015 at 03:31:14PM -0700, Mitchel Humpherys wrote: > We're currently using %lu and %ld to print some variables of type > dma_addr_t, which results in the following warning when dma_addr_t is > 64-bits wide: > > drivers/staging/android/ion/ion_chunk_heap.c: In function 'ion_chunk_heap_create': > drivers/staging/android/ion/ion_chunk_heap.c:176:2: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'dma_addr_t' [-Wformat=] > pr_info("%s: base %lu size %zu align %ld\n", __func__, chunk_heap->base, > ^ > drivers/staging/android/ion/ion_chunk_heap.c:176:2: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'dma_addr_t' [-Wformat=] > > Fix this by using %pa as instructed in printk-formats.txt. > > Signed-off-by: Mitchel Humpherys > --- > drivers/staging/android/ion/ion_chunk_heap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/android/ion/ion_chunk_heap.c b/drivers/staging/android/ion/ion_chunk_heap.c > index 3e6ec2ee6802..f0b7c8e68422 100644 > --- a/drivers/staging/android/ion/ion_chunk_heap.c > +++ b/drivers/staging/android/ion/ion_chunk_heap.c > @@ -173,8 +173,8 @@ struct ion_heap *ion_chunk_heap_create(struct ion_platform_heap *heap_data) > chunk_heap->heap.ops = &chunk_heap_ops; > chunk_heap->heap.type = ION_HEAP_TYPE_CHUNK; > chunk_heap->heap.flags = ION_HEAP_FLAG_DEFER_FREE; > - pr_info("%s: base %lu size %zu align %ld\n", __func__, chunk_heap->base, > - heap_data->size, heap_data->align); > + pr_info("%s: base %pa size %zu align %pa\n", __func__, > + &chunk_heap->base, heap_data->size, &heap_data->align); Shouldn't this be a debug message, and not printed out for everyone to see all the time? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/