Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754704AbbDIWs6 (ORCPT ); Thu, 9 Apr 2015 18:48:58 -0400 Received: from mail-ig0-f177.google.com ([209.85.213.177]:33263 "EHLO mail-ig0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753284AbbDIWs4 (ORCPT ); Thu, 9 Apr 2015 18:48:56 -0400 MIME-Version: 1.0 In-Reply-To: <1428618674-1370-1-git-send-email-mitchelh@codeaurora.org> References: <1428618674-1370-1-git-send-email-mitchelh@codeaurora.org> Date: Thu, 9 Apr 2015 15:48:55 -0700 X-Google-Sender-Auth: Iz3EBAZq8duF2YulE4EuEE5aYTs Message-ID: Subject: Re: [PATCH] staging: ion: chunk_heap: use %pa for printing dma_addr_t's From: Colin Cross To: Mitchel Humpherys Cc: devel@linuxdriverproject.org, Greg Kroah-Hartman , Android Kernel Team , John Stultz , lkml Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2443 Lines: 47 On Thu, Apr 9, 2015 at 3:31 PM, Mitchel Humpherys wrote: > We're currently using %lu and %ld to print some variables of type > dma_addr_t, which results in the following warning when dma_addr_t is > 64-bits wide: > > drivers/staging/android/ion/ion_chunk_heap.c: In function 'ion_chunk_heap_create': > drivers/staging/android/ion/ion_chunk_heap.c:176:2: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'dma_addr_t' [-Wformat=] > pr_info("%s: base %lu size %zu align %ld\n", __func__, chunk_heap->base, > ^ > drivers/staging/android/ion/ion_chunk_heap.c:176:2: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'dma_addr_t' [-Wformat=] > > Fix this by using %pa as instructed in printk-formats.txt. According to printk-formats.txt, dma_addr_t needs to be printed with %pad. > Signed-off-by: Mitchel Humpherys > --- > drivers/staging/android/ion/ion_chunk_heap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/android/ion/ion_chunk_heap.c b/drivers/staging/android/ion/ion_chunk_heap.c > index 3e6ec2ee6802..f0b7c8e68422 100644 > --- a/drivers/staging/android/ion/ion_chunk_heap.c > +++ b/drivers/staging/android/ion/ion_chunk_heap.c > @@ -173,8 +173,8 @@ struct ion_heap *ion_chunk_heap_create(struct ion_platform_heap *heap_data) > chunk_heap->heap.ops = &chunk_heap_ops; > chunk_heap->heap.type = ION_HEAP_TYPE_CHUNK; > chunk_heap->heap.flags = ION_HEAP_FLAG_DEFER_FREE; > - pr_info("%s: base %lu size %zu align %ld\n", __func__, chunk_heap->base, > - heap_data->size, heap_data->align); > + pr_info("%s: base %pa size %zu align %pa\n", __func__, > + &chunk_heap->base, heap_data->size, &heap_data->align); > > return &chunk_heap->heap; > > -- > Qualcomm Innovation Center, Inc. > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/