Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755758AbbDIW5h (ORCPT ); Thu, 9 Apr 2015 18:57:37 -0400 Received: from g1t5424.austin.hp.com ([15.216.225.54]:45957 "EHLO g1t5424.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753386AbbDIW5f (ORCPT ); Thu, 9 Apr 2015 18:57:35 -0400 X-Greylist: delayed 165617 seconds by postgrey-1.27 at vger.kernel.org; Thu, 09 Apr 2015 18:57:35 EDT Message-ID: <55270386.4060304@hp.com> Date: Thu, 09 Apr 2015 16:56:06 -0600 From: Thavatchai Makphaibulchoke User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Thomas Gleixner CC: Steven Rostedt , Thavatchai Makphaibulchoke , linux-kernel@vger.kernel.org, mingo@redhat.com, linux-rt-users@vger.kernel.org, umgwanakikbuti@gmail.com, Peter Zijlstra , Sebastian Andrzej Siewior Subject: Re: [PATCH v2 1/2] rtmutex Real-Time Linux: Fixing kernel BUG at kernel/locking/rtmutex.c:997! References: <1424395866-81589-1-git-send-email-tmac@hp.com> <1428369962-74723-1-git-send-email-tmac@hp.com> <1428369962-74723-2-git-send-email-tmac@hp.com> <20150406215959.4e8ad37b@grimm.local.home> <55247C96.1080707@hp.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 878 Lines: 36 On 04/08/2015 02:50 AM, Thomas Gleixner wrote: > > Don't even try to get this working. Taking the lock in idle/interrupt > context is just plain wrong. > Thanks for the comments. Could you please confirm you meant rt_mutex as it can go to sleep. > The proper solution is to get rid of the locking requirement and that > needs some thought on the timer wheel code. > Yes, I agree fixing the problem in the timer code is the proper solution. BTW, once the code is fixed, I think we should add WARN_ON(in_irq()); to the function spin_do_trylock() to prevent any invalid future usage. Thanks, Mak. > Thanks, > > tglx > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/