Date: Thu, 9 Apr 2015 16:12:12 -0700 (PDT)
From: David Rientjes <rientjes@google.com>
To: Arnd Bergmann <arnd@arndb.de>
cc: linux-arm-kernel@lists.infradead.org,
        Andrey Ryabinin <a.ryabinin@samsung.com>, linux-mm@kvack.org,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mempool: add missing include
In-Reply-To: <6079838.EgducKeYG3@wuerfel>
Message-ID: <alpine.DEB.2.10.1504091608410.21208@chino.kir.corp.google.com>
References: <3302342.cNyRUGN06P@wuerfel> <alpine.DEB.2.10.1504091230400.11370@chino.kir.corp.google.com> <6079838.EgducKeYG3@wuerfel>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1655
Lines: 38

On Thu, 9 Apr 2015, Arnd Bergmann wrote:

> > > This is a fix^3 for the mempool poisoning patch, which introduces
> > > a compile-time error on some ARM randconfig builds:
> > > 
> > > mm/mempool.c: In function 'check_element':
> > > mm/mempool.c:65:16: error: implicit declaration of function 'kmap_atomic' [-Werror=implicit-function-declaration]
> > >    void *addr = kmap_atomic((struct page *)element);
> > > 
> > > The problem is clearly the missing declaration, and including
> > > linux/highmem.h fixes it.
> > > 
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > Fixes: a3db5a8463b0db ("mm, mempool: poison elements backed by page allocator fix fix")
> > 
> > Acked-by: David Rientjes <rientjes@google.com>
> > 
> > Thanks!  Can you confirm that this is because CONFIG_BLOCK is disabled and 
> > not something else?
> 
> Unfortunately I've lost the information which build was responsible
> for this error (normally I keep it, but my script failed here because the
> same config introduced two new regressions). CONFIG_BLOCK sounds plausible
> here.
> 
> If necessary, I can repeat the last few hundred builds without this
> patch to find out what it was.
> 

Ok, thanks.  The only reason I ask is because if this is CONFIG_BLOCK then 
it shouldn't be arm specific and nothing else has reported it.  I'll do a 
randconfig loop with my arm cross-compiler and see if I can find any other 
issues.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/