Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932264AbbDIXWp (ORCPT ); Thu, 9 Apr 2015 19:22:45 -0400 Received: from mail-ie0-f170.google.com ([209.85.223.170]:34426 "EHLO mail-ie0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754300AbbDIXWm (ORCPT ); Thu, 9 Apr 2015 19:22:42 -0400 MIME-Version: 1.0 In-Reply-To: References: <3302342.cNyRUGN06P@wuerfel> <6079838.EgducKeYG3@wuerfel> Date: Thu, 9 Apr 2015 16:22:41 -0700 Message-ID: Subject: Re: [PATCH] mempool: add missing include From: Jim Davis To: David Rientjes Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Andrey Ryabinin , linux-mm@kvack.org, Andrew Morton , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1829 Lines: 41 On Thu, Apr 9, 2015 at 4:12 PM, David Rientjes wrote: > On Thu, 9 Apr 2015, Arnd Bergmann wrote: > >> > > This is a fix^3 for the mempool poisoning patch, which introduces >> > > a compile-time error on some ARM randconfig builds: >> > > >> > > mm/mempool.c: In function 'check_element': >> > > mm/mempool.c:65:16: error: implicit declaration of function 'kmap_atomic' [-Werror=implicit-function-declaration] >> > > void *addr = kmap_atomic((struct page *)element); >> > > >> > > The problem is clearly the missing declaration, and including >> > > linux/highmem.h fixes it. >> > > >> > > Signed-off-by: Arnd Bergmann >> > > Fixes: a3db5a8463b0db ("mm, mempool: poison elements backed by page allocator fix fix") >> > >> > Acked-by: David Rientjes >> > >> > Thanks! Can you confirm that this is because CONFIG_BLOCK is disabled and >> > not something else? >> >> Unfortunately I've lost the information which build was responsible >> for this error (normally I keep it, but my script failed here because the >> same config introduced two new regressions). CONFIG_BLOCK sounds plausible >> here. >> >> If necessary, I can repeat the last few hundred builds without this >> patch to find out what it was. >> > > Ok, thanks. The only reason I ask is because if this is CONFIG_BLOCK then > it shouldn't be arm specific and nothing else has reported it. The random configuration file included in http://marc.info/?l=linux-mm&m=142851035816974&w=2 doesn't have CONFIG_BLOCK set. That build failure was on an x86_32 system. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/