Date: Fri, 10 Apr 2015 12:16:39 +0300
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Ingi Kim <ingi2.kim@samsung.com>
Cc: cooloney@gmail.com, rpurdie@rpsys.net, robh+dt@kernel.org,
        pawel.moll@arm.com, mark.rutland@arm.com,
        ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
        j.anaszewski@samsung.com, varkabhadram@gmail.com, joe@perches.com,
        sw0312.kim@samsung.com, cw00.choi@samsung.com, jh80.chung@samsung.com,
        ideal.song@samsung.com, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v6 3/3] leds: Add ktd2692 flash LED driver
Message-ID: <20150410091639.GG20756@valkosipuli.retiisi.org.uk>
References: <1428648359-23289-1-git-send-email-ingi2.kim@samsung.com>
 <1428648359-23289-4-git-send-email-ingi2.kim@samsung.com>
 <20150410081106.GF20756@valkosipuli.retiisi.org.uk>
 <55278DAA.40700@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55278DAA.40700@samsung.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 724
Lines: 26

Hi Ingi,

On Fri, Apr 10, 2015 at 05:45:30PM +0900, Ingi Kim wrote:
...
> >> +	ret = devm_gpio_request_one(dev, led->ctrl_gpio,
> >> +					GPIOF_OPEN_SOURCE, "ctrl-gpio");
> >
> > I think you could simply use devm_gpio_get(), and start using the new API
> > instead. It'd save quite a few lines of code, too.
> >
> 
> did you mean devm_gpiod_get()
> Ok, I'll check it

Yes, that's what I meant.

-- 
Regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/