Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755844AbbDJMLU (ORCPT ); Fri, 10 Apr 2015 08:11:20 -0400 Received: from mail.skyhub.de ([78.46.96.112]:46026 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754894AbbDJMLT (ORCPT ); Fri, 10 Apr 2015 08:11:19 -0400 Date: Fri, 10 Apr 2015 14:09:05 +0200 From: Borislav Petkov To: Quentin Casasnovas Cc: X86 ML , LKML Subject: Re: [PATCH 07/13] x86/microcode/intel: Rename update_match_revision() Message-ID: <20150410120905.GD28074@pd.tnic> References: <1424774232-5981-1-git-send-email-bp@alien8.de> <1424774232-5981-8-git-send-email-bp@alien8.de> <20150224162318.GG4565@chrystal.uk.oracle.com> <20150410111218.GC28074@pd.tnic> <20150410115455.GA23346@chrystal.uk.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150410115455.GA23346@chrystal.uk.oracle.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 845 Lines: 27 On Fri, Apr 10, 2015 at 01:54:56PM +0200, Quentin Casasnovas wrote: > BTW, I could not find that the 'rev' argument to get_matching_sig() was > used at all.. That's the next patch in the queue for 4.2 :-) > If we're to rename 'rev', maybe calling it 'cpu_rev' would make it more > obvious where this variable is coming from? It is actually a microcode revision. I.e., microcode patch version number. I'll add doc comments after the cleanup is done. > Anyway you patch looks good to me! Thanks, I'll add your ACK. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/