Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932474AbbDJMdW (ORCPT ); Fri, 10 Apr 2015 08:33:22 -0400 Received: from mail-lb0-f180.google.com ([209.85.217.180]:33418 "EHLO mail-lb0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932135AbbDJMdS (ORCPT ); Fri, 10 Apr 2015 08:33:18 -0400 MIME-Version: 1.0 In-Reply-To: <1428668396-6955-3-git-send-email-gpramod@codeaurora.org> References: <1428668396-6955-1-git-send-email-gpramod@codeaurora.org> <1428668396-6955-3-git-send-email-gpramod@codeaurora.org> Date: Fri, 10 Apr 2015 09:33:16 -0300 Message-ID: Subject: Re: [PATCH v3 3/3] tty: serial: msm: replaces (1 << x) with BIT(x) macro From: Fabio Estevam To: Pramod Gurav Cc: linux-arm-msm@vger.kernel.org, "linux-serial@vger.kernel.org" , linux-kernel , Greg Kroah-Hartman , bryanh@codeaurora.org, Stephen Boyd , Jiri Slaby Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 910 Lines: 28 On Fri, Apr 10, 2015 at 9:19 AM, Pramod Gurav wrote: > -#define UART_TF 0x000C > -#define UARTDM_TF 0x0070 > +#define UART_TF 0x000C > +#define UARTDM_TF 0x0070 This is a different change, so it should be part of a different patch. > -#define UART_IPR 0x0018 > -#define UART_TFWR 0x001C > -#define UART_RFWR 0x0020 > -#define UART_HCR 0x0024 > +#define UART_IPR 0x0018 > +#define UART_TFWR 0x001C > +#define UART_RFWR 0x0020 > +#define UART_HCR 0x0024 Same here. Regards, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/