Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933248AbbDJMib (ORCPT ); Fri, 10 Apr 2015 08:38:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40076 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756057AbbDJMi2 (ORCPT ); Fri, 10 Apr 2015 08:38:28 -0400 Date: Fri, 10 Apr 2015 14:38:05 +0200 From: Jiri Olsa To: He Kuang Cc: =?iso-8859-1?Q?J=E9r=E9mie?= Galarneau , Sebastian Andrzej Siewior , Jiri Olsa , acme@kernel.org, a.p.zijlstra@chello.nl, mingo@redhat.com, Wang Nan , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] perf data: Fix ctf_writer setupenv failure Message-ID: <20150410123805.GA22510@krava.brq.redhat.com> References: <1428468560-27401-1-git-send-email-hekuang@huawei.com> <1428468560-27401-2-git-send-email-hekuang@huawei.com> <20150408175947.GB20250@krava.redhat.com> <55262C8D.8080109@huawei.com> <55277E2D.6030809@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <55277E2D.6030809@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1422 Lines: 39 On Fri, Apr 10, 2015 at 03:39:25PM +0800, He Kuang wrote: > Hi, J?r?mie > On 2015/4/10 3:57, J?r?mie Galarneau wrote: > >Hi He, > > > >This commit should fix the problem: > > > >commit a0d129162d2fdd1a99553a6cfbdf4e77ad3f7334 > >Author: J?r?mie Galarneau > >Date: Thu Apr 9 14:57:44 2015 -0400 > > > > Fix: Allow the addition of environment fields to a frozen trace > > > > Commit 7f800dc7 introduced a behavior change which made it > > impossible to add environment fields to a frozen trace (after the > > creation of a stream). > > > > This fix makes it possible to add new fields to a trace's > > environment while making it impossible to modify existing fields > > hereby restoring CTF Writer's v1.2 behavior. > > > > Signed-off-by: J?r?mie Galarneau > > > >Can you reproduce the problem with the latest Babeltrace master? > >Otherwise, is there a branch I can checkout to try it out? > > > >J?r?mie > > By updating to the latest libbabeltrace which contains commit > a0d12916, perf ctf conversion works with or without my patch. works nicely for me too, thanks! jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/