Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932701AbbDJMt3 (ORCPT ); Fri, 10 Apr 2015 08:49:29 -0400 Received: from mail.kernel.org ([198.145.29.136]:35751 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932446AbbDJMt2 (ORCPT ); Fri, 10 Apr 2015 08:49:28 -0400 Date: Fri, 10 Apr 2015 09:49:29 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: David Ahern , linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim Subject: Re: [PATCH] perf tool: Fix cross-endian analysis Message-ID: <20150410124929.GC4521@kernel.org> References: <1428610546-178789-1-git-send-email-david.ahern@oracle.com> <20150410082726.GA27593@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150410082726.GA27593@krava> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1636 Lines: 44 Em Fri, Apr 10, 2015 at 10:27:26AM +0200, Jiri Olsa escreveu: > On Thu, Apr 09, 2015 at 04:15:46PM -0400, David Ahern wrote: > > Trying to analyze a big endian data file on little endian system > > fails with the error: > > 0xa9b40 [0x70]: failed to process type: 9 > > > > The problem is that header parsing is not done correctly because > > the file attributes are not swapped. Make it so. With this patch > > able to analyze a sparc64 data file on x86_64. > > > > Signed-off-by: David Ahern > > Cc: Jiri Olsa > > Cc: Namhyung Kim > > --- > > tools/perf/util/header.c | 5 ++++- > > 1 files changed, 4 insertions(+), 1 deletions(-) > > > > diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c > > index e38cf62..45b7e72 100644 > > --- a/tools/perf/util/header.c > > +++ b/tools/perf/util/header.c > > @@ -2586,8 +2586,11 @@ int perf_session__read_header(struct perf_session *session) > > if (read_attr(fd, header, &f_attr) < 0) > > goto out_errno; > > > > - if (header->needs_swap) > > + if (header->needs_swap) { > > + f_attr.ids.size = bswap_64(f_attr.ids.size); > > + f_attr.ids.offset = bswap_64(f_attr.ids.offset); > > perf_event__attr_swap(&f_attr.attr); > > + } > > so people do actually use it ;-) > > Acked-by: Jiri Olsa Thanks, applied. - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/