Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756190AbbDJRZE (ORCPT ); Fri, 10 Apr 2015 13:25:04 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:57038 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751554AbbDJRZB (ORCPT ); Fri, 10 Apr 2015 13:25:01 -0400 Message-ID: <5528076B.1010808@codeaurora.org> Date: Fri, 10 Apr 2015 10:24:59 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Srinivas Kandagatla , galak@codeaurora.org, linux-arm-msm@vger.kernel.org CC: Mark Rutland , devicetree@vger.kernel.org, Russell King , Pawel Moll , Ian Campbell , linux-kernel@vger.kernel.org, Rob Herring , bjorn.andersson@sonymobile.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 05/12] ARM: dts: apq8064: Add SATA controller support. References: <1428669187-10775-1-git-send-email-srinivas.kandagatla@linaro.org> <1428669263-10990-1-git-send-email-srinivas.kandagatla@linaro.org> In-Reply-To: <1428669263-10990-1-git-send-email-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1737 Lines: 55 On 04/10/15 05:34, Srinivas Kandagatla wrote: > This patch adds AHCI based SATA controller support to APQ8064. > Tested on IFC6410 board. > > Signed-off-by: Srinivas Kandagatla > --- > arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 9 ++++++++ > arch/arm/boot/dts/qcom-apq8064.dtsi | 35 ++++++++++++++++++++++++++++++ > 2 files changed, 44 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts > index 122bf34..c9c9c5e 100644 > --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts > +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts > @@ -116,6 +116,15 @@ > }; > }; > > + sata_phy0: sata-phy@1b400000{ Space before '{' please. > + status = "okay"; > + }; > + > + sata0: sata@29000000 { > + status = "okay"; > + target-supply = <&pm8921_s4>; > + }; > + > /* OTG */ > usb1_phy: phy@12500000 { > status = "okay"; > diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi > index 5aac9a5..56cc65e 100644 > --- a/arch/arm/boot/dts/qcom-apq8064.dtsi > +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi > @@ -379,6 +379,41 @@ > usb-phy = <&usb4_phy>; > }; > > + sata_phy0: sata-phy@1b400000{ Space before '{' please. Also I wonder if it should just be called phy@1b400000 because phy is more standard than sata-phy. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/