Message-ID: <1428688440.17822.33.camel@x220>
Subject: Re: [PATCH v5 09/11] ARM: vf610: enable Cortex-M4 configuration on
 Vybrid SoC
From: Paul Bolle <pebolle@tiscali.nl>
To: Stefan Agner <stefan@agner.ch>
Cc: shawn.guo@linaro.org, kernel@pengutronix.de, linux@arm.linux.org.uk,
        u.kleine-koenig@pengutronix.de, jason@lakedaemon.net, olof@lixom.net,
        arnd@arndb.de, daniel.lezcano@linaro.org, tglx@linutronix.de,
        mark.rutland@arm.com, pawel.moll@arm.com, robh+dt@kernel.org,
        ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
        marc.zyngier@arm.com, mcoquelin.stm32@gmail.com,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Date: Fri, 10 Apr 2015 19:54:00 +0200
In-Reply-To: <1428609855-27657-10-git-send-email-stefan@agner.ch>
References: <1428609855-27657-1-git-send-email-stefan@agner.ch>
	 <1428609855-27657-10-git-send-email-stefan@agner.ch>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1309
Lines: 53

Just two whitespace nits. (Please don't tell anyone, I'm a bit
embarrassed that I even spot them, let alone that I comment on them.)

On Thu, 2015-04-09 at 22:04 +0200, Stefan Agner wrote:
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug

> @@ -629,10 +631,26 @@ config SOC_IMX6SX
>  	help
>  	  This enables support for Freescale i.MX6 SoloX processor.
>  
> +

This second empty line is unneeded.

> +config SOC_LS1021A
> +	bool "Freescale LS1021A support"
> +	select ARM_GIC
> +	select HAVE_ARM_ARCH_TIMER
> +	select PCI_DOMAINS if PCI
> +	select ZONE_DMA if ARM_LPAE
> +

Please drop this empty line.

> +	help
> +	  This enable support for Freescale LS1021A processor.
> +
> +endif
> +
> +comment "Cortex-A/Cortex-M asymmetric multiprocessing platforms"
> +
> +if ARCH_MULTI_V7 || ARM_SINGLE_ARMV7M
> +
>  config SOC_VF610
>  	bool "Vybrid Family VF610 support"
> -	select IRQ_DOMAIN_HIERARCHY
> -	select ARM_GIC
> +	select ARM_GIC if ARCH_MULTI_V7
>  	select PINCTRL_VF610
>  	select PL310_ERRATA_769419 if CACHE_L2X0
>  

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/