Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754894AbbDJSaJ (ORCPT ); Fri, 10 Apr 2015 14:30:09 -0400 Received: from smtp-1.atlantis.sk ([92.240.247.91]:45315 "EHLO smtp-1.atlantis.sk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754892AbbDJSaG (ORCPT ); Fri, 10 Apr 2015 14:30:06 -0400 X-Greylist: delayed 332 seconds by postgrey-1.27 at vger.kernel.org; Fri, 10 Apr 2015 14:30:05 EDT From: Ondrej Zary To: Sudip Mukherjee Subject: Re: [PATCH WIP] parport: add device model Date: Fri, 10 Apr 2015 20:24:23 +0200 User-Agent: KMail/1.9.10 (enterprise35 0.20100827.1168748) Cc: gregkh@linuxfoundation.org, dan.carpenter@oracle.com, linux-kernel@vger.kernel.org References: <1428676238-17141-1-git-send-email-sudipm.mukherjee@gmail.com> In-Reply-To: <1428676238-17141-1-git-send-email-sudipm.mukherjee@gmail.com> X-KMail-QuotePrefix: > MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <201504102024.24220.linux@rainbow-software.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1594 Lines: 34 On Friday 10 April 2015 16:30:38 Sudip Mukherjee wrote: > This is work-in-progree, not for applying to any tree. Posting now for > your comments so that I know if I am in the proper track. > > in parport_register_driver() driver is registered but i am not linking > anywhere the device with the driver, but yet when I am testing this > patch I am seeing in sys tree that parport0 is linked with > the lp driver. Is it done in the device core? I am missing this step > somewhere. > > In parport_claim() the attach is unchecked as of now, I think we will > need my initial patch series of monitoring the attach return value along > with it. > > while testing I am getting NULL dereference with daisy.c, and after > disabling PARPORT_1284 , I am getting some new errors. so if you are > testing this patch please keep in mind that still lots of work is > pending. > My main intention to post it now is to know if my approach is correct. Many newer parallel port devices support plug&play (IEEE1284 device ID) but Linux never supported it properly. The ID is probed and even the class is printed in the kernel log (drivers/parport/probe.c) but there's no support for module autoloading based on that. This could be a good opportunity to add this support. I was thinking about this while playing with some parport webcams recently. -- Ondrej Zary -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/