Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755719AbbDJScj (ORCPT ); Fri, 10 Apr 2015 14:32:39 -0400 Received: from mail-wg0-f50.google.com ([74.125.82.50]:33113 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751554AbbDJScg (ORCPT ); Fri, 10 Apr 2015 14:32:36 -0400 Message-ID: <5528173F.6000509@linaro.org> Date: Fri, 10 Apr 2015 19:32:31 +0100 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Stephen Boyd , galak@codeaurora.org, linux-arm-msm@vger.kernel.org CC: Mark Rutland , devicetree@vger.kernel.org, Russell King , Pawel Moll , Ian Campbell , linux-kernel@vger.kernel.org, Rob Herring , bjorn.andersson@sonymobile.com, Nicolas Dechesne , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 09/12] ARM: dts: apq8064: Add USB OTG support for CM QS-600 References: <1428669187-10775-1-git-send-email-srinivas.kandagatla@linaro.org> <1428669293-11165-1-git-send-email-srinivas.kandagatla@linaro.org> <552807CF.4070600@codeaurora.org> In-Reply-To: <552807CF.4070600@codeaurora.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1751 Lines: 64 On 10/04/15 18:26, Stephen Boyd wrote: > On 04/10/15 05:34, Srinivas Kandagatla wrote: >> From: Nicolas Dechesne >> >> This patch adds USB OTG support on USB1 for Compulab QS-600 Board. >> >> Signed-off-by: Srinivas Kandagatla >> [Srinivas Kandagatla: fixed up regulators and status properties] >> Signed-off-by: Nicolas Dechesne >> --- >> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts >> index fc69931..d353694 100644 >> --- a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts >> +++ b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts >> @@ -101,6 +101,14 @@ >> }; >> }; >> >> + /* OTG */ >> + usb1_phy:phy@12500000 { > > Space after that ':' please. > Yep, I will fix it in next version. >> + status = "okay"; >> + vddcx-supply = <&pm8921_s3>; >> + v3p3-supply = <&pm8921_l3>; >> + v1p8-supply = <&pm8921_l4>; >> + }; >> + >> usb3_phy:phy@12520000 { >> status = "okay"; >> vddcx-supply = <&pm8921_s3>; >> @@ -115,6 +123,15 @@ >> v1p8-supply = <&pm8921_l23>; >> }; >> >> + gadget1:gadget@12500000 { >> + status = "ok"; >> + }; >> + >> + /* OTG */ >> + usb1: usb@12500000 { > > This one is good. > >> + status = "ok"; >> + }; >> + >> usb3: usb@12520000 { >> status = "okay"; >> }; > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/