Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756588AbbDJWBp (ORCPT ); Fri, 10 Apr 2015 18:01:45 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:58903 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756493AbbDJWBm (ORCPT ); Fri, 10 Apr 2015 18:01:42 -0400 From: Arnd Bergmann To: Greg Kroah-Hartman Cc: linux-serial@vger.kernel.org, Jiri Slaby , linux-kernel@vger.kernel.org, Chanwoo Choi , tfiga@google.com, Marek Szyprowski , Alim Akhtar , linux-arm-kernel@lists.infradead.org Subject: [PATCH] serial: earlycon requires console support Date: Sat, 11 Apr 2015 00:01:32 +0200 Message-ID: <5009638.HyplLv73fU@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:xvY0ogPbz9u6MgaRYTZP0WOjQ8pKjjPftObnRQl18iPNDh5aMof gYFyUQBBFJHhxU5jotlUHkcrGEVTWDS56Mpw1daNEIvdIEP7QWHnLU0rO29wmtbmAGcqqxU G1/XTOvAIOL0PI6beDbOsQTl4AFa73/JZ3xtW7akgmEOFzG2y2ic1tCnyLGD1IFZk8pQq7F c6WawLp3TVre6LW4PMlRA== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1230 Lines: 31 A configuration that enables earlycon but not the core console code causes a link error: drivers/built-in.o: In function `setup_earlycon': drivers/tty/serial/earlycon.c:70: undefined reference to `uart_parse_earlycon' That error can be triggered by the newly added samsung earlycon support, which is missing a 'select' statement. This patch adds the 'select' to make serial-samsung behave like the other drivers. Signed-off-by: Arnd Bergmann Fixes: b94ba0328d3b3 ("serial: samsung: Add support for early console") diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index f8120c1bde14..5cd8f38a36de 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -241,6 +241,7 @@ config SERIAL_SAMSUNG tristate "Samsung SoC serial support" depends on PLAT_SAMSUNG || ARCH_EXYNOS select SERIAL_CORE + select SERIAL_CORE_CONSOLE select SERIAL_EARLYCON help Support for the on-chip UARTs on the Samsung S3C24XX series CPUs, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/