Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756321AbbDKAaT (ORCPT ); Fri, 10 Apr 2015 20:30:19 -0400 Received: from seldrel01.sonyericsson.com ([212.209.106.2]:1389 "EHLO seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753233AbbDKAaR (ORCPT ); Fri, 10 Apr 2015 20:30:17 -0400 Date: Fri, 10 Apr 2015 17:30:05 -0700 From: Bjorn Andersson To: Paul Bolle CC: Kumar Gala , Andy Gross , David Brown , Jeffrey Hugo , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-soc@vger.kernel.org" Subject: Re: [PATCH 2/2] soc: qcom: Add Shared Memory Manager driver Message-ID: <20150411003004.GC12607@sonymobile.com> References: <1428102200-5948-1-git-send-email-bjorn.andersson@sonymobile.com> <1428102200-5948-2-git-send-email-bjorn.andersson@sonymobile.com> <1428146178.7898.75.camel@x220> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1428146178.7898.75.camel@x220> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2067 Lines: 61 On Sat 04 Apr 04:16 PDT 2015, Paul Bolle wrote: > On Fri, 2015-04-03 at 16:03 -0700, Bjorn Andersson wrote: > > --- a/drivers/soc/qcom/Kconfig > > +++ b/drivers/soc/qcom/Kconfig > > > +config QCOM_SMEM > > + tristate "Qualcomm Shared Memory Manager (SMEM)" > > + depends on ARCH_QCOM > > + help > > + Say y here to enable support for the Qualcomm Shared Memory Manager. > > + The driver provides an interface to items in a heap shared among all > > + processors in a Qualcomm platform. > > > --- a/drivers/soc/qcom/Makefile > > +++ b/drivers/soc/qcom/Makefile > > @@ -1 +1,2 @@ > > > +obj-$(CONFIG_QCOM_SMEM) += smem.o > > Just to make absolutely sure I'm not misreading this Makefile: if > QCOM_SMEM is set to 'm' this will generate the module smem.ko, right? > Right. > > --- /dev/null > > +++ b/drivers/soc/qcom/smem.c > > @@ -0,0 +1,763 @@ > > +/* > > + * Copyright (c) 2015, Sony Mobile Communications AB. > > + * Copyright (c) 2012-2013, The Linux Foundation. All rights reserved. > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 and > > + * only version 2 as published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > > +MODULE_LICENSE("GPLv2"); > > "GPLv2" doesn't indicate a GPL compatible license according to > include/linux/license.h. Loading smem.ko should trigger a warning and > taint the kernel. So you want > MODULE_LICENSE("GPL v2"); > > here. Thanks for noticing, I will correct this. Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/