Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932837AbbDKMWP (ORCPT <rfc822;w@1wt.eu>);
	Sat, 11 Apr 2015 08:22:15 -0400
Received: from mail.kernel.org ([198.145.29.136]:55576 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932561AbbDKMWN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sat, 11 Apr 2015 08:22:13 -0400
Date: Sat, 11 Apr 2015 09:22:03 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: David Ahern <dsahern@gmail.com>, Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Re: [RFE] perf probe: Support globbing/regex in -a
Message-ID: <20150411122203.GB3200@kernel.org>
References: <20150408194826.GI5403@kernel.org>
 <55260DD8.50409@hitachi.com>
 <20150409103638.GK5403@kernel.org>
 <55286A12.6050309@hitachi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <55286A12.6050309@hitachi.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3249
Lines: 91

Em Sat, Apr 11, 2015 at 09:25:54AM +0900, Masami Hiramatsu escreveu:
> (2015/04/09 19:36), Arnaldo Carvalho de Melo wrote:
> > Em Thu, Apr 09, 2015 at 02:27:52PM +0900, Masami Hiramatsu escreveu:
> >> (2015/04/09 4:48), Arnaldo Carvalho de Melo wrote:
> >>> 	In tools/perf constructors are named <CLASS>__new, and right now I want
> >>> to know hoe many of each <CLASS> objects are being allocated, so I expected to
> >>> be able to do:

> >>> [root@zoo ~]# perf probe -x ~/bin/perf -a "*__new"
> >>> Probe point '*__new' not found.
> >>>   Error: Failed to add events.
> >>> [root@zoo ~]#

> >> Actually, I had sent it　:)

> >> https://lkml.org/lkml/2014/10/31/207
> >> https://lkml.org/lkml/2014/10/31/213

> >> I'll update and resend the wildcard support.

> > Oops, but it was together with that cache thing, could it be sent
> > separately?
 
> Yes, it can be applied separately. However, it may open the Pandora's box,
> which we have to face to someday anyway :)

yeah!
 
>  - "perf probe -a \*" can try to put probes on all functions in the kernel
>    including the inline functions. The total number of probes will be
>    more than one hundred-thousand (100,000)...
>  - Currently ftrace-kprobe doesn't limit the number of dynamic events, so
>    it can cause out of memory on some machine.
>  - Also, enabling such events at once, could cause performance problem,

So don't do it?

>    which I had tackled last year. See below slide.
> http://events.linuxfoundation.org/sites/events/files/slides/Handling%20the%20Massive%20Multiple%20Kprobes%20v2_1.pdf
>    (note that this series is not applied yet)
 
> So, currently perf probe limits the maximum number of definable events at once
> you can expand it with --max-probes anyway. And also, I've introduced --no-inlines
> option to perf probe which reduces the number of matched functions when user
> puts the probes with wild cards. (I'm considering to apply this option automatically
> if the function name includes wild cards)

I.e. we have some mechanisms in place to limit the number of probes,
user gets warned when that limit is hit, no problem, right?

And on top of that, you already have a patchkit that tries to reduce the
overhead, good deal! :-)

I'll look again at those patches and see if they apply.

Thanks for all the info about this topic, appreciated!

- Arnaldo
 
> Thank you,
> 
> > 
> > <SNIP>
> >  
> >>> Also that -l should output to stdout, so that we can grep it, also it would be nice if it -l worked
> >>> like in perf list:
> >>>
> >>> [root@zoo ~]# perf probe -l probe_perf:*
> >>> Semantic error :There is non-digit char in line number.
> >>>   Error: Command Parse Error.
> >>
> >> Hmm, right. This should be fixed.
> > 
> > Thanks!
> > 
> > - Arnaldo
> > 
> 
> 
> -- 
> Masami HIRAMATSU
> Linux Technology Research Center, System Productivity Research Dept.
> Center for Technology Innovation - Systems Engineering
> Hitachi, Ltd., Research & Development Group
> E-mail: masami.hiramatsu.pt@hitachi.com
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/