Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755343AbbDKNSy (ORCPT ); Sat, 11 Apr 2015 09:18:54 -0400 Received: from www.osadl.org ([62.245.132.105]:58004 "EHLO www.osadl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753473AbbDKNSx (ORCPT ); Sat, 11 Apr 2015 09:18:53 -0400 From: Nicholas Mc Guire To: David Airlie Cc: Rob Clark , Mark Brown , Stephen Rothwell , Hai Li , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Nicholas Mc Guire Subject: [PATCH 2/3] drm/msm: wait_for_completion_timeout return is never negative Date: Sat, 11 Apr 2015 15:10:37 +0200 Message-Id: <1428757838-10431-2-git-send-email-hofrat@osadl.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1428757838-10431-1-git-send-email-hofrat@osadl.org> References: <1428757838-10431-1-git-send-email-hofrat@osadl.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1168 Lines: 36 wait_for_completion_timeout returns >= 0 but never negative - so the error check should be against equality to 0 not <= 0. Signed-off-by: Nicholas Mc Guire --- This was compile tested with qcom_defconfig + CONFIG_DRM=m (implies CONFIG_DRM_MSM=m) Patch is against 4.0-rc7 (localversion-next is -next-20150410) drivers/gpu/drm/msm/edp/edp_ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/edp/edp_ctrl.c b/drivers/gpu/drm/msm/edp/edp_ctrl.c index 831acd6..9ef361c 100644 --- a/drivers/gpu/drm/msm/edp/edp_ctrl.c +++ b/drivers/gpu/drm/msm/edp/edp_ctrl.c @@ -1032,7 +1032,7 @@ static void edp_ctrl_off_worker(struct work_struct *work) time_left = wait_for_completion_timeout(&ctrl->idle_comp, msecs_to_jiffies(500)); - if (time_left <= 0) + if (!time_left) DBG("%s: idle pattern timedout, %lu\n", __func__, time_left); -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/