Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932393AbbDKO4k (ORCPT ); Sat, 11 Apr 2015 10:56:40 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:51051 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752661AbbDKO4h (ORCPT ); Sat, 11 Apr 2015 10:56:37 -0400 From: Arnd Bergmann To: Paul Bolle Cc: Gabriel FERNANDEZ , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Srinivas Kandagatla , Maxime Coquelin , Patrice Chotard , Russell King , Bjorn Helgaas , Jingoo Han , Lucas Stach , Fabrice Gasnier , Kishon Vijay Abraham I , Andrew Morton , "David S. Miller" , Greg KH , Mauro Carvalho Chehab , Joe Perches , Tejun Heo , Viresh Kumar , Thierry Reding , Phil Edworthy , Minghuan Lian , Tanmay Inamdar , m-karicheri2@ti.com, Sachin Kamat , Andrew Lunn , Liviu Dudau , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@stlinux.com, linux-pci@vger.kernel.org, Lee Jones , Gabriel Fernandez Subject: Re: [PATCH v3 3/5] PCI: st: Provide support for the sti PCIe controller Date: Sat, 11 Apr 2015 16:55:50 +0200 Message-ID: <2529595.kpEIoZMpcn@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1428747477.17822.90.camel@x220> References: <1428657168-12495-1-git-send-email-gabriel.fernandez@linaro.org> <1428657168-12495-4-git-send-email-gabriel.fernandez@linaro.org> <1428747477.17822.90.camel@x220> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:C0El8fAbRfp+GbqiaQ9XknVqHX9lDLVTVw4Vd9Gvj2mysEEuOfC /Fzdz2zkreXdVyL8uUZMVE6x/bHejMvA/TVaHYc0p0cMGg26cpTUTV5Xy+hc/Bwn3xA3XM4 QE8puBUfOSo68f7pNBjNdFZnpr0hFGBAXohQGX9Kvtf8SPQl7a3qajSXEKl0uVNdnxUfANN rbhWksRAtoc6GqCTI37WQ== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1966 Lines: 49 On Saturday 11 April 2015 12:17:57 Paul Bolle wrote: > Something I didn't spot in my first look at this patch. > > On Fri, 2015-04-10 at 11:12 +0200, Gabriel FERNANDEZ wrote: > > --- a/drivers/pci/host/Kconfig > > +++ b/drivers/pci/host/Kconfig > > > > +config PCI_ST > > + bool "ST PCIe controller" > > + depends on ARCH_STI || (ARM && COMPILE_TEST) > > + select PCIE_DW > > + help > > + Enable PCIe controller support on ST Socs. This controller is based > > + on Designware hardware and therefore the driver re-uses the > > + Designware core functions to implement the driver. > > You can't have ARCH_STI without ARM, so ARM will always be set if this > driver is enabled. Correct? Right, though the ARM dependency could soon be dropped, once the PCIE_DW driver can use generic infrastructure in the few places it relies on ARM specific code today. > > --- /dev/null > > +++ b/drivers/pci/host/pci-st.c > > > + if (IS_ENABLED(CONFIG_ARM)) { > > + /* > > + * We have to hook the abort handler so that we can intercept > > + * bus errors when doing config read/write that return UR, > > + * which is flagged up as a bus error > > + */ > > + hook_fault_code(16+6, st_pcie_abort_handler, SIGBUS, 0, > > + "imprecise external abort"); > > + } > > So, unless I'm missing something obvious here, IS_ENABLED(CONFIG_ARM) > will always evaluate to 1. Can't that test be dropped? I would leave it in, as it's quite likely to get reused with ARM64 at some point in the future (no, I don't know anything about ST's product plans, but everybody seems to be doing this). Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/