Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751742AbbDLNHw (ORCPT ); Sun, 12 Apr 2015 09:07:52 -0400 Received: from mail-ig0-f180.google.com ([209.85.213.180]:36805 "EHLO mail-ig0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751098AbbDLNHq (ORCPT ); Sun, 12 Apr 2015 09:07:46 -0400 MIME-Version: 1.0 In-Reply-To: <7a9107efdfe64b0d9e9d93421595badb@www.loen.fr> References: <1423128277-10297-1-git-send-email-bintian.wang@huawei.com> <1423128277-10297-4-git-send-email-bintian.wang@huawei.com> <20150205193017.GF20735@leverpostej> <7a9107efdfe64b0d9e9d93421595badb@www.loen.fr> Date: Sun, 12 Apr 2015 21:07:43 +0800 Message-ID: Subject: Re: [PATCH 3/3] arm64: dts: Add dts files for Hisilicon Hi6220 SoC From: Brent Wang To: Marc Zyngier Cc: Mark Rutland , "dan.zhao@hisilicon.com" , "btw@mail.itp.ac.cn" , Catalin Marinas , "wangbinghui@hisilicon.com" , Will Deacon , "huxinwei@huawei.com" , Kevin Hilman , Haojian Zhuang , Haifeng Yan , Rob Herring , Mike Turquette , "victor.lixin@hisilicon.com" , Xu Wei , Jaehoon Chung , "sledge.yanwei@huawei.com" , XinWei Kong , "heyunlei@huawei.com" , "w.f@huawei.com" , Zhangfei Gao , "z.liuxinliang@huawei.com" , "devicetree@vger.kernel.org" , Bintian Wang , Pawel Moll , Ian Campbell , "puck.chen@hisilicon.com" , Olof Johansson , Rob Herring , Russell King - ARM Linux , "zhenwei.wang@hisilicon.com" , linux-arm-kernel , Guodong Xu , Tomeu Vizoso , Stephen Boyd , "linux-kernel@vger.kernel.org" , Kumar Gala , "xuejiancheng@huawei.com" , "xuyiping@hisilicon.com" , "Liguozhu (Kenneth)" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1645 Lines: 61 Hello Marc, 2015-04-12 18:57 GMT+08:00 Marc Zyngier : > On 2015-04-12 07:40, Brent Wang wrote: >> >> Hello Mark, >> >> 2015-02-06 16:42 GMT+08:00 Brent Wang : >> [...] >>>> >>>> >>>>> + gic: interrupt-controller@f6800000 { >>>>> + compatible = "arm,gic-400", "arm,cortex-a15-gic"; >>>> >>>> >>>> Surely there's no need for the "arm,cortex-a15-gic" fallback entry? What >>>> am I missing? >>> >>> Remove it in next version. >> >> After remove "arm,cortex-a15-gic", I get the following error during >> kernel booting: >> ----- >> kvm [1]: Using HYP init bounce page @396d9000 >> kvm [1]: error: no compatible GIC node found >> kvm [1]: error initializing Hyp mode: -19 >> ----- >> >> Check code "virt/kvm/arm/vgic.c", gicv2 only "cortex-a15-gic" and >> gicv3 support kvm now, >> so I think we should keep it, how about your idea? > > > Please look at commit 0f37247574b3 that is queued for merge in 4.1. > It adds the required compatibility strings to KVM, so Mark is perfectly > right to ask you to drop this "cortex-a15-gic" from your DT. Thanks for the information. > This DT won't be merged before 4.1 anyway, so there is no point trying > to make it work with older kernels. > > Thanks, > > M. > -- > Fast, cheap, reliable. Pick two. -- Best Regards, Bintian =========================== Don't be nervous, just be happy! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/