Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751877AbbDLPAv (ORCPT ); Sun, 12 Apr 2015 11:00:51 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:60214 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751251AbbDLPAu (ORCPT ); Sun, 12 Apr 2015 11:00:50 -0400 Message-ID: <552A889F.6050307@roeck-us.net> Date: Sun, 12 Apr 2015 08:00:47 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Jeff Epler CC: Richard Weinberger , Chris Zankel , Max Filippov , linux-xtensa@linux-xtensa.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xtensa: Fix execdomain removal References: <1428805191-27089-1-git-send-email-linux@roeck-us.net> <20150412144346.GD7215@unpythonic.net> In-Reply-To: <20150412144346.GD7215@unpythonic.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020202.552A88A1.018D,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.000 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 1 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 976 Lines: 28 On 04/12/2015 07:43 AM, Jeff Epler wrote: > On Sat, Apr 11, 2015 at 07:19:51PM -0700, Guenter Roeck wrote: >> The removal of exexdomain changes pointer offsets into the thread_info >> structure. > ... >> -#define TI_EXEC_DOMAIN 0x00000004 >> -#define TI_FLAGS 0x00000008 >> +#define TI_FLAGS 0x00000004 > > Hmm. If these have to be maintained by hand, perhaps they can be > BUILD_BUG_ON'd in some appropriate C file? e.g., > > BUILD_BUG_ON(TI_FLAGS != offsetof(struct thread_info, flags)); > > Jeff > Other architectures use either DEFINE or OFFSET macros to define those flags, so that would probably be a better solution if something more fancy is asked for. That should probably be a separate patch, though. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/