Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751739AbbDLPCO (ORCPT ); Sun, 12 Apr 2015 11:02:14 -0400 Received: from mail-wg0-f47.google.com ([74.125.82.47]:33625 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751098AbbDLPCL (ORCPT ); Sun, 12 Apr 2015 11:02:11 -0400 MIME-Version: 1.0 In-Reply-To: <1428791102.17822.175.camel@x220> References: <1428537385-15089-1-git-send-email-gregory.0xf0@gmail.com> <1428701143.17822.72.camel@x220> <1428778617.17822.133.camel@x220> <1428783814.17822.150.camel@x220> <1428791102.17822.175.camel@x220> Date: Sun, 12 Apr 2015 17:02:10 +0200 X-Google-Sender-Auth: N2Zfru8hqMayHtKQCH1YSykYL8U Message-ID: Subject: Re: [PATCH 1/2] kconfig: Print full defined and depends for multiply-defined symbols From: Stefan Hengelein To: Paul Bolle Cc: Gregory Fong , Michal Marek , Valentin Rothberg , Andreas Ruprecht , Martin Walch , linux-kbuild@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1734 Lines: 40 > Let's focus, for example, on m32r and FRAME_POINTER. The m32r entry for > that symbol reads: > config FRAME_POINTER > bool "Compile the kernel with frame pointers" > help > If you say Y here [...] > > 0) If one is building for m32r is that all there's to it? If so, "make > menuconfig"'s search facility is serving the people building for m32r a > load of crap. > > 1) If it's actually more complicated than that I think that anyone > reading arch/m32r/Kconfig.debug is being duped. Things look simple but > actually they are quite complicated. I think that's just wrong. > > What am I missing here? If you have a look at the definitions, lib/Kconfig.debug is included before FRAME_POINTER is defined in m32r and the output in the search facility looks indeed broken as one "Defined at" is missing but there are somehow Location entries (-> Kernel hacking and -> Kernel hacking -> compile time checks and [...]) for both definitions in a weird order (i think (1) and (2) might indicate both definitions) both declarations are valid in kconfig, you have two ways of enabling the same symbol, one easy without conditions and one with conditions and both with the same prompt. The search facility shows the first one that is found, you see the complicated depends on but i think the text shown might not be explicit enough to clarify you don't need to satisfy these complicated conditions to actually choose a value. Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/