Message-ID: <552A9A52.7070706@hurleysoftware.com>
Date: Sun, 12 Apr 2015 12:16:18 -0400
From: Peter Hurley <peter@hurleysoftware.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Valentin Rothberg <valentinrothberg@gmail.com>, gregkh@linuxfoundation.org,
        jslaby@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/tty/nozomi.c: rename CONFIG_MAGIC
References: <1428850561-4311-1-git-send-email-valentinrothberg@gmail.com>
In-Reply-To: <1428850561-4311-1-git-send-email-valentinrothberg@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1764
Lines: 53

Hi Valentin,

On 04/12/2015 10:56 AM, Valentin Rothberg wrote:
> The CONFIG_ prefix is reserved for Kconfig options in Make and CPP
> syntax.  CONFIG_MAGIC is a file local CPP identifier so strip the prefix
> to apply to Kconfig's naming convention.
> 
> Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
> ---
> I found this issue with ./scripts/checkkconfigsymbols.py
> ---
>  drivers/tty/nozomi.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c
> index 74885af8c7bd..4a4775e81963 100644
> --- a/drivers/tty/nozomi.c
> +++ b/drivers/tty/nozomi.c
> @@ -140,7 +140,7 @@ static int debug;
>  #define R_FCR		0x0000	/* Flow Control Register */
>  #define R_IER		0x0004	/* Interrupt Enable Register */
>  
> -#define CONFIG_MAGIC	0xEFEFFEFE
> +#define MAGIC			0xEFEFFEFE
           ^^^^^
This is too general for a preprocessor symbol; how about
NOZOMI_CONFIG_MAGIC?

Regards,
Peter Hurley

>  #define TOGGLE_VALID	0x0000
>  
>  /* Definition of interrupt tokens */
> @@ -660,9 +660,9 @@ static int nozomi_read_config_table(struct nozomi *dc)
>  	read_mem32((u32 *) &dc->config_table, dc->base_addr + 0,
>  						sizeof(struct config_table));
>  
> -	if (dc->config_table.signature != CONFIG_MAGIC) {
> +	if (dc->config_table.signature != MAGIC) {
>  		dev_err(&dc->pdev->dev, "ConfigTable Bad! 0x%08X != 0x%08X\n",
> -			dc->config_table.signature, CONFIG_MAGIC);
> +			dc->config_table.signature, MAGIC);
>  		return 0;
>  	}
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/