Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752149AbbDLUHp (ORCPT ); Sun, 12 Apr 2015 16:07:45 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:51878 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751901AbbDLUHn (ORCPT ); Sun, 12 Apr 2015 16:07:43 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Krzysztof Kozlowski , Kukjin Kim , devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Olof Johansson , Marek Szyprowski Subject: Re: [PATCH 0/7] ARM: dts: Refactor Exynos5 boards for phandle notation Date: Sun, 12 Apr 2015 22:07:02 +0200 Message-ID: <2603418.sEMfdEBYRq@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1428841494-20769-1-git-send-email-k.kozlowski.k@gmail.com> References: <1428841494-20769-1-git-send-email-k.kozlowski.k@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:U2PL7jx5iDYuFjHlHlxPSa4LQg8VfIvfLNOVzUIXfAxFjPMcvps THAdqnwSMdXoS0q6Bvr17bJSlTtt2XF5uEpteSCeO3DHpj0oUD4Gw2jOT+O1qO5anfz4vBF dC2W4XqmNf0DC/hCvb3VHE6QoSWxeeRF1lfM3+K1v3xCdVHlJiF1YINYT/oakMk6HsuMXtR G3+Qnn/Y59JcI+t01Os3g== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 894 Lines: 25 On Sunday 12 April 2015 21:24:47 Krzysztof Kozlowski wrote: > > The phandle notation reduces possible mistakes when overriding nodes > by child board files and reduces duplication of addresses. > > The patchset refactors Exynos5 boards to use the phandle way. > > Tested by comparison of decompiled DTB for each commit. The patches look fine, but the description is wrong as you are not using 'phandles' here, you are using 'labels'. A phandle is a reference to another device node inside of a property, and while that is normally done using labels like interrupt-parent = <&gic>; you can just as well use the full path in a phandle. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/