Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752854AbbDMDsK (ORCPT ); Sun, 12 Apr 2015 23:48:10 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:33896 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752542AbbDMDsG (ORCPT ); Sun, 12 Apr 2015 23:48:06 -0400 Message-ID: <552B3C74.9030004@wwwdotorg.org> Date: Sun, 12 Apr 2015 21:48:04 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Linus Walleij CC: Charles Keepax , Ray Jui , Lee Jones , "linux-gpio@vger.kernel.org" , linux-rpi-kernel@lists.infradead.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] pinctrl: bcm2835: Fix support for threaded level triggered IRQs References: <1428403425-12058-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1000 Lines: 23 On 04/08/2015 08:43 AM, Linus Walleij wrote: > On Tue, Apr 7, 2015 at 12:43 PM, Charles Keepax > wrote: > >> Currently, the driver uses handle_simple_irq for all IRQ types and hard >> codes the acknowledge for different IRQ types into the handler. It is >> better to use the IRQ core as intended and let it handle the differences >> between the various types of IRQ. For example the current system does >> not work for threaded level triggered IRQs as these need to be masked >> until the threaded handler has run. >> >> Signed-off-by: Charles Keepax > > Looks like a very fine patch so applied unless Stephen has > some problem with it. This patch sounds plausible to me:-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/