Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753014AbbDMHkc (ORCPT ); Mon, 13 Apr 2015 03:40:32 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:34678 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751787AbbDMHkY (ORCPT ); Mon, 13 Apr 2015 03:40:24 -0400 Message-ID: <552B72DF.2080600@profitbricks.com> Date: Mon, 13 Apr 2015 09:40:15 +0200 From: Michael Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Jason Gunthorpe , Doug Ledford CC: "ira.weiny" , Roland Dreier , Sean Hefty , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, Hal Rosenstock , Tom Tucker , Steve Wise , Hoang-Nam Nguyen , Christoph Raisch , Mike Marciniszyn , Eli Cohen , Faisal Latif , Upinder Malhi , Trond Myklebust , "J. Bruce Fields" , "David S. Miller" , PJ Waskiewicz , Tatyana Nikolova , Or Gerlitz , Jack Morgenstein , Haggai Eran , Ilya Nelkenbaum , Yann Droneaud , Bart Van Assche , Shachar Raindel , Sagi Grimberg , Devesh Sharma , Matan Barak , Moni Shoua , Jiri Kosina , Selvin Xavier , Mitesh Ahuja , Li RongQing , Rasmus Villemoes , Alex Estrin , Eric Dumazet , Erez Shitrit , Tom Gundersen , Chuck Lever Subject: Re: [PATCH v2 01/17] IB/Verbs: Implement new callback query_transport() for each HW References: <5523CCD5.6030401@profitbricks.com> <5523D098.3020007@profitbricks.com> <1428517786.2980.180.camel@redhat.com> <20150410074805.GA11855@phlsvsds.ph.intel.com> <1428685843.2980.353.camel@redhat.com> <20150410173650.GB26419@obsidianresearch.com> In-Reply-To: <20150410173650.GB26419@obsidianresearch.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1770 Lines: 47 On 04/10/2015 07:36 PM, Jason Gunthorpe wrote: > On Fri, Apr 10, 2015 at 01:10:43PM -0400, Doug Ledford wrote: > >> documented. I get why you link the address variant, because it pops out >> all the things that are special about IBoE addressing and calls out that >> the issues need to be handled. However, saying requires_iboe_addr(), >> while foreshadowing the work that needs done, doesn't actually document >> the work that needs done. Whether we call is dev_is_iboe() or >> requires_iboe_addr(), it would be good if the documentation spelled out >> those specific requirements for reference sake. > > My deep hope for this, was that the test 'requires_iboe_addr' or > whatever we call it would have a *really good* kdoc. > > List all the ways iboe_addr's work, how they differ from IB addresses, > refer to the specs people should read to understand it, etc. > > The patches don't do this, and maybe Michael is the wrong person to > fill that in, but we can get it done.. That's exactly what I'm thinking ;-) At first I'm just trying to save us some code but now it's becoming a topic far above that purpose, I'd like to help commit whatever we already settled and pass the internal reforming works to experts like you guys , implement the bitmask stuff ;-) And I can still help on review and may be testing with mlx4 if later I got the access. > > Jason > > BTW: Michael, next time you post the series, please trim the CC > list... Thanks for the remind, I'll do trim in v3 :-) Regards, Michael Wang > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/