Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753501AbbDMIfO (ORCPT ); Mon, 13 Apr 2015 04:35:14 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48397 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752435AbbDMIfM (ORCPT ); Mon, 13 Apr 2015 04:35:12 -0400 Date: Mon, 13 Apr 2015 10:37:25 +0200 From: Petr Mladek To: Minfei Huang Cc: jpoimboe@redhat.com, sjenning@redhat.com, jkosina@suse.cz, vojtech@suse.cz, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] livepatch: Add a new function to verify the address and name match for extra module Message-ID: <20150413083725.GA16088@pathway.suse.cz> References: <1428844554-4015-1-git-send-email-minfei.huang@hotmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 911 Lines: 21 On Sun 2015-04-12 21:15:53, Minfei Huang wrote: > In order to restrict the patch, we can verify the provided function > address and name match. Now we have can only verify the vmlinux function > name and address. > > Add a new function to verify extra module function name and address. The > patch would not be patched, if the function name and address are not > matched. old_addr could be predefined only for vmlinux. It does not make sense to define it for modules because they are loaded dynamically, each time on a different addresses. It means that it does not make sense to verify addresses from modules. They always need to be detected. Best Regards, Petr -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/