Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753686AbbDMJ5P (ORCPT <rfc822;w@1wt.eu>);
	Mon, 13 Apr 2015 05:57:15 -0400
Received: from pandora.arm.linux.org.uk ([78.32.30.218]:53984 "EHLO
	pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932164AbbDMJ5I (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 13 Apr 2015 05:57:08 -0400
Date: Mon, 13 Apr 2015 10:56:45 +0100
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Gregory Fong <gregory.0xf0@gmail.com>
Cc: "Wang, Yalin" <Yalin.Wang@sonymobile.com>, Mel Gorman <mgorman@suse.de>,
        Laura Abbott <lauraa@codeaurora.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Kees Cook <keescook@chromium.org>, Nicolas Pitre <nico@linaro.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        open list <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "vishnu.ps@samsung.com" <vishnu.ps@samsung.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH] ARM: print cma-reserved pages from show_mem
Message-ID: <20150413095645.GQ12732@n2100.arm.linux.org.uk>
References: <CADtm3G7CUYUUbmTrWiudQ5j-wX9hu86Ox8TkB+FnXwEvjb=xeg@mail.gmail.com>
 <20150210113230.GJ8656@n2100.arm.linux.org.uk>
 <CADtm3G64rPf7O76xUbLwqsqTkJxdGJMT9sHj810xPuThDA0ddg@mail.gmail.com>
 <20150326114612.GD8656@n2100.arm.linux.org.uk>
 <20150326123028.GM4701@suse.de>
 <CADtm3G4Lb=u+BAHZF+O+RgB4VS9iW8epCPJ9ssBTj=+p3+h==Q@mail.gmail.com>
 <35FD53F367049845BC99AC72306C23D104A310D42397@CNBJMBX05.corpusers.net>
 <20150410112430.GB12732@n2100.arm.linux.org.uk>
 <20150413010913.GA15225@corellia.local>
 <20150413012115.GB15225@corellia.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150413012115.GB15225@corellia.local>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1043
Lines: 24

On Sun, Apr 12, 2015 at 06:21:15PM -0700, Gregory Fong wrote:
> On Sun, Apr 12, 2015 at 06:09:13PM -0700, Gregory Fong wrote:
> > And now we see 83 slab_reclaimable + 846 slab_unreclaimable adds up
> > correctly to the total of 929.
> > 
> > The patch below will end up with the correct count.
> > 
> 
> Sorry, messed up the patch formatting.  Here it is fixed:

So now the question is: do we fix this, or do we use the generic version?
Given that the total number of slab pages can be easily deduced from the
generic statistics, do we need to modify the generic version to print an
additional line with this?  It seems wasteful to do so, and just adds
more noise to the kernel's debug output.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/