Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753853AbbDMKFz (ORCPT ); Mon, 13 Apr 2015 06:05:55 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:54013 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753449AbbDMKFy (ORCPT ); Mon, 13 Apr 2015 06:05:54 -0400 Date: Mon, 13 Apr 2015 11:05:38 +0100 From: Russell King - ARM Linux To: Mel Gorman Cc: Gregory Fong , "Wang, Yalin" , Laura Abbott , Florian Fainelli , Kees Cook , Nicolas Pitre , Catalin Marinas , open list , "linux-arm-kernel@lists.infradead.org" , "vishnu.ps@samsung.com" , Marek Szyprowski , Johannes Weiner Subject: Re: [PATCH] ARM: print cma-reserved pages from show_mem Message-ID: <20150413100538.GR12732@n2100.arm.linux.org.uk> References: <20150326114612.GD8656@n2100.arm.linux.org.uk> <20150326123028.GM4701@suse.de> <35FD53F367049845BC99AC72306C23D104A310D42397@CNBJMBX05.corpusers.net> <20150410112430.GB12732@n2100.arm.linux.org.uk> <20150413010913.GA15225@corellia.local> <20150413012115.GB15225@corellia.local> <20150413095645.GQ12732@n2100.arm.linux.org.uk> <20150413100425.GB14842@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150413100425.GB14842@suse.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1458 Lines: 32 On Mon, Apr 13, 2015 at 11:04:26AM +0100, Mel Gorman wrote: > On Mon, Apr 13, 2015 at 10:56:45AM +0100, Russell King - ARM Linux wrote: > > On Sun, Apr 12, 2015 at 06:21:15PM -0700, Gregory Fong wrote: > > > On Sun, Apr 12, 2015 at 06:09:13PM -0700, Gregory Fong wrote: > > > > And now we see 83 slab_reclaimable + 846 slab_unreclaimable adds up > > > > correctly to the total of 929. > > > > > > > > The patch below will end up with the correct count. > > > > > > > > > > Sorry, messed up the patch formatting. Here it is fixed: > > > > So now the question is: do we fix this, or do we use the generic version? > > Given that the total number of slab pages can be easily deduced from the > > generic statistics, do we need to modify the generic version to print an > > additional line with this? > > Whatever ARM decides, I do not think the generic version needs to do > a PFN walk to recaluate the SLAB statistics. The slab_reclaimable and > slab_unreclaimable stats based on the vmstat counters is sufficient. Yes, I agree. My feeling is we just switch to the generic version and be done with it. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/