Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932273AbbDMK5o (ORCPT ); Mon, 13 Apr 2015 06:57:44 -0400 Received: from mail-lb0-f169.google.com ([209.85.217.169]:35807 "EHLO mail-lb0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753740AbbDMK5j (ORCPT ); Mon, 13 Apr 2015 06:57:39 -0400 Date: Mon, 13 Apr 2015 12:57:44 +0200 From: Christoffer Dall To: Alex =?iso-8859-1?Q?Benn=E9e?= Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com, peter.maydell@linaro.org, agraf@suse.de, drjones@redhat.com, pbonzini@redhat.com, zhichao.huang@linaro.org, jan.kiszka@siemens.com, dahi@linux.vnet.ibm.com, r65777@freescale.com, bp@suse.de, Gleb Natapov , "open list:ABI/API" , open list Subject: Re: [PATCH v2 01/10] KVM: add commentary for kvm_debug_exit_arch struct Message-ID: <20150413105744.GL6186@cbox> References: <1427814488-28467-1-git-send-email-alex.bennee@linaro.org> <1427814488-28467-2-git-send-email-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1427814488-28467-2-git-send-email-alex.bennee@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1583 Lines: 54 On Tue, Mar 31, 2015 at 04:07:59PM +0100, Alex Benn?e wrote: > Bring into line with the commentary for the other structures and their > KVM_EXIT_* cases. > > Signed-off-by: Alex Benn?e > > --- > > v2 > - add comments for other exit types > > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > index 8055706..5eedf84 100644 > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h > @@ -226,6 +226,7 @@ struct kvm_run { > __u32 count; > __u64 data_offset; /* relative to kvm_run start */ > } io; > + /* KVM_EXIT_DEBUG */ > struct { > struct kvm_debug_exit_arch arch; > } debug; > @@ -274,6 +275,7 @@ struct kvm_run { > __u32 data; > __u8 is_write; > } dcr; > + /* KVM_EXIT_INTERNAL_ERROR */ > struct { > __u32 suberror; > /* Available with KVM_CAP_INTERNAL_ERROR_DATA: */ > @@ -284,6 +286,7 @@ struct kvm_run { > struct { > __u64 gprs[32]; > } osi; > + /* KVM_EXIT_PAPR_HCALL */ > struct { > __u64 nr; > __u64 ret; > -- > 2.3.4 > I'm fine with this change as it is, but I think it should update the documenation of the kvm_run structure along with it, and in there it seems the debug struct is listed as 'unused'; this should be addressed in this patch set somewhere if we start using this struct? -Christoffer -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/