Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932310AbbDMM3u (ORCPT ); Mon, 13 Apr 2015 08:29:50 -0400 Received: from mail-qk0-f178.google.com ([209.85.220.178]:35032 "EHLO mail-qk0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932282AbbDMM3r (ORCPT ); Mon, 13 Apr 2015 08:29:47 -0400 MIME-Version: 1.0 In-Reply-To: <20150413100538.GR12732@n2100.arm.linux.org.uk> References: <20150326114612.GD8656@n2100.arm.linux.org.uk> <20150326123028.GM4701@suse.de> <35FD53F367049845BC99AC72306C23D104A310D42397@CNBJMBX05.corpusers.net> <20150410112430.GB12732@n2100.arm.linux.org.uk> <20150413010913.GA15225@corellia.local> <20150413012115.GB15225@corellia.local> <20150413095645.GQ12732@n2100.arm.linux.org.uk> <20150413100425.GB14842@suse.de> <20150413100538.GR12732@n2100.arm.linux.org.uk> From: Gregory Fong Date: Mon, 13 Apr 2015 05:29:16 -0700 Message-ID: Subject: Re: [PATCH] ARM: print cma-reserved pages from show_mem To: Russell King - ARM Linux Cc: Mel Gorman , "Wang, Yalin" , Laura Abbott , Florian Fainelli , Kees Cook , Nicolas Pitre , Catalin Marinas , open list , "linux-arm-kernel@lists.infradead.org" , "vishnu.ps@samsung.com" , Marek Szyprowski , Johannes Weiner Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1892 Lines: 42 On Mon, Apr 13, 2015 at 3:05 AM, Russell King - ARM Linux wrote: > On Mon, Apr 13, 2015 at 11:04:26AM +0100, Mel Gorman wrote: >> On Mon, Apr 13, 2015 at 10:56:45AM +0100, Russell King - ARM Linux wrote: >> > On Sun, Apr 12, 2015 at 06:21:15PM -0700, Gregory Fong wrote: >> > > On Sun, Apr 12, 2015 at 06:09:13PM -0700, Gregory Fong wrote: >> > > > And now we see 83 slab_reclaimable + 846 slab_unreclaimable adds up >> > > > correctly to the total of 929. >> > > > >> > > > The patch below will end up with the correct count. >> > > > >> > > >> > > Sorry, messed up the patch formatting. Here it is fixed: >> > >> > So now the question is: do we fix this, or do we use the generic version? >> > Given that the total number of slab pages can be easily deduced from the >> > generic statistics, do we need to modify the generic version to print an >> > additional line with this? >> >> Whatever ARM decides, I do not think the generic version needs to do >> a PFN walk to recaluate the SLAB statistics. The slab_reclaimable and >> slab_unreclaimable stats based on the vmstat counters is sufficient. > > Yes, I agree. My feeling is we just switch to the generic version and be > done with it. Agreed. This is really what I was hoping for in the first place, but didn't know before submitting the initial patch whether there was some arcane reason for the arm-specific show_mem. If someone like Yalin really wants the total slab pages, they can just add slab_unreclaimable and slab_reclaimable (btw, Yalin, all emails I've sent to you are bouncing, maybe you'll see this since it's going to the list). Thanks, Gregory -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/